Fix #5196: setLowLODElement crash when LOD element is a building - #5201
Open
x6c85 wants to merge 5 commits into
Open
Fix #5196: setLowLODElement crash when LOD element is a building#5201x6c85 wants to merge 5 commits into
x6c85 wants to merge 5 commits into
Conversation
Member
|
Please resolve conflicts |
auto-merge was automatically disabled
August 25, 2026 10:44
Head branch was pushed to by a user without write access
FileEX
enabled auto-merge (squash)
September 10, 2026 21:50
auto-merge was automatically disabled
September 11, 2026 15:48
Head branch was pushed to by a user without write access
Member
|
Please fix the clang-format issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
setLowLODElementcould crash the client when both the high-detail element and the LOD were buildings. After #5139 a building in another dimension (or one that failed to allocate) has no native GTA entity (m_pBuilding == nullptr), butCClientBuilding::SetLowLodBuildingstill calledSetLodon that pointer.The MTA-side high/low link is now stored even if the native entities are missing,
SetLodis only called when both exist, andCreate()restores the GTA LOD link once the building is actually created.Motivation
Fixes #5196. Building-to-building LOD is supported (wiki:
createBuilding+createBuilding+setLowLODElement); it just shouldn't crash. This matches the report that it reproduced in a gamemode but not always via runcode.Test plan
Client should not crash. Also check:
createBuilding+createObject(..., true)+setLowLODElementstill worksChecklist