Repository navigation
Gate live browser cookie test behind opt-in - #902
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 36 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title is a short imperative summary that accurately describes gating the live browser cookie test behind opt-in execution. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
| Provider Data Stays Siloed | |
PASS. The pull request changes only the live cookie test in rust/src/browser/cookies.rs. It adds an opt-in environment check, marks the test ignored, and changes output from cookie name/value prefix… |
| Secrets Handled Safely | |
The pull request removes the live test's cookie-value output. The changed test now logs only a count, cookie names, a fixed opt-in message, or CookieError text; it no longer prints any cookie value … |
| No Unapproved Dependencies | |
The pull request changes only rust/src/browser/cookies.rs. It does not change any Cargo.toml, package.json, npm or yarn lockfile, or pnpm packageManager version. No dependency addition require… |
| Ui Changes Include Windows Proof | |
The pull request changes only the live test in rust/src/browser/cookies.rs. It does not modify desktop UI files, tray rendering, the float bar, settings, or window chrome. The PR description correct… |
Full details: Provider Data Stays Siloed
-
Explanation
PASS. The pull request changes only the live cookie test in
rust/src/browser/cookies.rs. It adds an opt-in environment check, marks the test ignored, and changes output from cookie name/value prefixes to cookie names only. It does not add provider or account identity handling, cross-provider UI/payload/storage behavior, or cross-provider branching.
Full details: Secrets Handled Safely
-
Explanation
The pull request removes the live test's cookie-value output. The changed test now logs only a count, cookie names, a fixed opt-in message, or
CookieErrortext; it no longer prints any cookie value or prefix. The test is also ignored by default and requiresCODEXBAR_LIVE_COOKIE_TEST=1. The diff introduces no credential-file or keyring deletion or overwrite.
Full details: No Unapproved Dependencies
-
Explanation
The pull request changes only
rust/src/browser/cookies.rs. It does not change anyCargo.toml,package.json, npm or yarn lockfile, or pnpmpackageManagerversion. No dependency addition requires approval.
Full details: Ui Changes Include Windows Proof
-
Explanation
The pull request changes only the live test in
rust/src/browser/cookies.rs. It does not modify desktop UI files, tray rendering, the float bar, settings, or window chrome. The PR description correctly states that UI proof is not applicable.
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
1 participant
Summary
browser::cookies::tests::test_cookie_extractionran in everycargo test. It read and decrypted realclaude.aicookies from the machine's installed browsers and printed the first 20 characters of each value.#[ignore](same pattern asproviders/claude/accounts.rs) and also returns early unlessCODEXBAR_LIVE_COOKIE_TEST=1is set, so--ignoredruns skip it too unless you opt in.No CI script runs
--ignored/--include-ignoredor sets the variable, so the test no longer runs in CI or in normal local runs.Not changed, listed for later:
browser/detection.rstest_browser_detectionreads real browser profile directories (paths and profile counts, no cookies).Commands run
cargo test --manifest-path rust/Cargo.toml browser: 129 passed, 1 ignored (test_cookie_extraction)cargo fmt --all: cleancargo clippyon both manifests with-D warnings: cleanUI proof
Not applicable: test-only change.
Summary by CodeRabbit