Repository navigation
Sprite tool: drop sky stuck to the subject, build the sprite in a worker - #38
Merged
Merged
Conversation
The subject cut could keep a cloud that touches the top or side edge, plus look-alike patches beside the head. dropEdgeLeak removes them unless that would take more than 35% of the subject. Building the sprite froze the page for up to a second; it now runs in a Web Worker and only the latest build is shown.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Viewers who turn a photo into a sprite get two fixes.
dropEdgeLeakinsrc/autosprite.tsremoves them. It backs off when that would remove more than 35% of the subject, so a duck on ice keeps its ice. Bench masks on the 9 test pictures match the approved run.src/sprite-worker.ts); a newer build replaces an older one. CSP needs no change (script-src 'self'covers a same-origin worker).Tests: a unit test for the leak removal in
tests/spritify.test.ts(red with either pass disabled).bun run check392 of 392,tests/ui.tsandtests/arena-browser.tspass locally. Docs:docs/CONTRACTS.mdviewer sprites.