Skip to content

Mirtrace topics migration#12183

Open
EfraMP wants to merge 2 commits into
nf-core:masterfrom
EfraMP:mirtrace_topics_migration
Open

Mirtrace topics migration#12183
EfraMP wants to merge 2 commits into
nf-core:masterfrom
EfraMP:mirtrace_topics_migration

Conversation

@EfraMP

@EfraMP EfraMP commented Jun 26, 2026

Copy link
Copy Markdown
Member

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@SPPearce SPPearce left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we simplify the snapshots here.
They are using a much older style, where there are lots of individual snapshot( ).match("foo") calls.

I think they could probably be replaced by snapshot(sanitizeOutput(process.out, unstableKeys: ["html", "json"])) for the non-stub test, and just snapshot(sanitizeOutput(process.out)) for the stub test.

@atrigila atrigila added the awaiting-changes will be closed after 30 days label Jul 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting-changes will be closed after 30 days

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants