update telescope version to 1.0.4#12218
Conversation
|
I think everything is resolved now, should be ready to merge, thanks for your help @mashehu |
|
something is off, because a change in the version should mean you would also need to update the snapshot 🤔 |
|
I am checking the container now, what the version output says there. |
|
Do I just need to run nf-core modules test on it to generate a new snapshot? If so I forgot to do that first, that's my fault! Can do now |
|
no the tests should fail, if you need to update the snapshots. |
|
okay, is it possible that they just updated the bioconda recipe and the version there (instead of the build number)? because the repo still shows 1.0.3 and the tool also reports that version (that's why the snapshot didn't need to be changed. |
|
Yes! It was me who updated the recipe & I didn't update the build number, sorry, didn't realise that was the reason |
|
since you own the fork with the fix. do you mind bumping the version in your fork https://github.com/hanalysis/telescope/blob/main/telescope/_version.py and then making a new bioconda build? |
3 participants
this update just updates the version of telescope so that is includes the argument --stranded_mode, no other changes.