Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We updated to Jackson 3 but swagger-core still pulls Jackson 2 jars into the WAR. The only thing we depend on from
swagger-coreare the Jackson mixins. Exclude the transitive dependencies ofswagger-core:hakunapi-corealready brings inswagger-models, andjackson-annotations(2.x, which Jackson 3 still uses) comes along with Jackson 3 databind.swagger-coreJackson MixinsOpenAPIMessageBodyWriteruses 11 Jackson mixins fromio.swagger.v3.core.jackson.mixinto serializeswagger-models POJOs beautifully (x-*extension flattening, hiding internal and OpenAPI 3.1-only getters)com.fasterxml.jackson.annotation(shared by Jackson 3) andswagger-models. Their three Jackson 2@JsonSerializeannotations are already ignored by Jackson 3; with databind 2 excluded the JDK drops themsilently.
swagger-corewith<exclusion>*:*</exclusion>NoClassDefFoundErrorif ever used, but nothing uses it.GoldenDocumentTest/api,/collections/{id}/schemaand/queryables, recorded before the pom change and unchanged after. Guards against a later unnoticed swagger-models getter leaking into/api.Behaviour change:
jackson-databind,jackson-core,jackson-dataformat-yaml,jackson-datatype-jsr310),snakeyaml,swagger-annotations,jakarta.xml.bind-api2.x andjakarta.activation-api1.x no longer arrive viahakunapi-simple-servlet-jakarta.