Conversation
The sqlite classes were renamed from DatabaseSync to Database. The file now imports only `Database`, but the "closes the iterator when a filter is reapplied to the cursor" test landed with a leftover `new DatabaseSync()` call, which throws a ReferenceError. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
trivikr
added
the
fast-track
Contributor
|
Fast-track has been requested by @trivikr. Please 👍 to approve. |
Collaborator
daeyeon
approved these changes
Sep 26, 2026
jasnell
approved these changes
Sep 26, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #66307 +/- ##
=======================================
Coverage 90.36% 90.37%
=======================================
Files 790 790
Lines 274292 274292
Branches 52510 52507 -3
=======================================
+ Hits 247874 247894 +20
+ Misses 16901 16895 -6
+ Partials 9517 9503 -14 🚀 New features to boost your workflow:
|
panva
approved these changes
Sep 26, 2026
panva
added
the
author ready
panva
pushed a commit
that referenced
this pull request
Sep 26, 2026
The sqlite classes were renamed from DatabaseSync to Database. The file now imports only `Database`, but the "closes the iterator when a filter is reapplied to the cursor" test landed with a leftover `new DatabaseSync()` call, which throws a ReferenceError. Signed-off-by: Trivikram Kamat <16024985+trivikr@users.noreply.github.com> PR-URL: #66307 Refs: #65988 Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Member
|
Landed in 38ad98a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #65988
The sqlite classes were renamed from DatabaseSync to Database. The file now imports only
Database, but the "closes the iterator when a filter is reapplied to the cursor" test landed with a leftovernew DatabaseSync()call, which throws a ReferenceError.