Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ jobs:
run: go build -v ./...

- name: Check generated code is up to date
env:
# Use the reviewed SDK schema while capture controls await API release.
NOTTE_API_URL: https://raw.githubusercontent.com/nottelabs/notte/a271724bc3ace49be3ec7d9c4617d87df1aa772d/openapi
run: |
go install github.com/oapi-codegen/oapi-codegen/v2/cmd/oapi-codegen@v2.5.1
./scripts/generate.sh
Expand Down
53 changes: 46 additions & 7 deletions internal/api/client.gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 16 additions & 0 deletions internal/cmd/sessionstart_flags.gen.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

39 changes: 39 additions & 0 deletions internal/cmd/sessionstart_flags_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -93,3 +93,42 @@ func TestAdvancedStealthMapping(t *testing.T) {
})
}
}

func TestCaptureFlagsPreserveFalseAndOmission(t *testing.T) {
for _, flag := range []string{"record-session", "log-session"} {
for _, value := range []string{"", "true", "false"} {
t.Run(flag+"/"+value, func(t *testing.T) {
cmd := newSessionStartFlagsCmd()
if value != "" {
cmd.SetArgs([]string{"--" + flag + "=" + value})
}
if err := cmd.Execute(); err != nil {
t.Fatal(err)
}
body, err := BuildSessionStartRequest(cmd)
if err != nil {
t.Fatal(err)
}
data, err := json.Marshal(body)
if err != nil {
t.Fatal(err)
}
var payload map[string]any
if err := json.Unmarshal(data, &payload); err != nil {
t.Fatal(err)
}
field := "record_session"
if flag == "log-session" {
field = "log_session"
}
got, present := payload[field]
if present != (value != "") {
t.Fatalf("%s presence=%v", field, present)
}
if present && got != (value == "true") {
t.Fatalf("%s = %v", field, got)
}
})
}
}
}
Loading