Skip to content

Add session recording and logging flags - #157

Merged
andreakiro merged 1 commit into
mainfrom
feat/session-capture-controls
Oct 27, 2026
Merged

andreakiro merged 1 commit into
mainfrom
feat/session-capture-controls

Conversation

@andreakiro

Copy link
Copy Markdown
Member

Expose --record-session and --log-session, including explicit false values and unchanged omission behavior. Regenerate the client from the public SDK schema and verify generation against that reviewed snapshot in CI.

Validated the full Go test suite and golangci-lint.

@andreakiro

Copy link
Copy Markdown
Member Author

@greptile review

@greptile-apps

greptile-apps Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no blocking issues were found.

Summary

Adds --record-session and --log-session, preserving explicit false values and leaving omitted fields out of requests.

  • Session starts can choose whether to save replays and browser logs.
  • The payment integration test starts its session with a named vault.

No new actionable issues were found in the changes since the previous review. Tests were not run during this review.

Reviews (2) · Last reviewed commit: "Give payment integration an isolated car..." · Reviewed by Greptile

greptile-apps[bot]
greptile-apps Bot previously approved these changes Oct 26, 2026
@greptile-apps
greptile-apps Bot dismissed their stale review October 26, 2026 22:23

Dismissed because a newer commit was pushed; Greptile will re-review the current head.

@andreakiro

Copy link
Copy Markdown
Member Author

@greptile review

The sandbox payment integration now uses its own empty card vault so it runs on a session with the required worker connection. It still asserts wallet_not_connected and connection guidance without approving a wallet or making a purchase. The payment lifecycle and SMS tests pass against staging; changed integration code has no lint findings.

@andreakiro
andreakiro force-pushed the feat/session-capture-controls branch from 8e212a6 to 00e7e2a Compare October 27, 2026 01:25
@andreakiro
andreakiro merged commit fbfe528 into main Oct 27, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant