Repository navigation
Merged
Conversation
…of the bare path map; count stored key.2..10 in the template gate (D-1156, D-1170)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
D-1156
`isBarePath` only ran the inline-credential screen when the value held a ":", so `myr,pass=x/y` mapped to `path://` and was echoed in the v1.4 notice and the schedule. Relative values with a `,key=` option shape (and no `./` or `../` prefix) are now left to the parser, which refuses them without echoing. `old,2026` and `./a,b=c` stay bare paths. Test cases added to `TestSettleBarePath`; they fail on main.
D-1170
`templateLicenseKeys` used `CollectLicenseKeys`, which reads only the primary key file. It now appends `license.GetAllStoredKeys()` (key, key.2 to key.10), deduped and trimmed, so a covered second key no longer gives a false E110. New `TestTemplateLicenseKeysStoredNumbered` fails on main.
D-1485
ALREADY-FIXED, no change: #968 (0a873b9) added `internal/cmdregistry/branches_test.go`; `go test -cover ./internal/cmdregistry/` reports 99.6% against the 96 floor.
Checks