[tonythethompson]

Stacked on #117: the base is the backlog branch because the backlog status change for this plugin lives there.

Why cargo_package exists

wangjiawen2013/charton is a Cargo workspace whose root package is the charton library; the Nushell plugin is a workspace member crate (nu_plugin_charton). The build workflow only ever built a repo's default package, so this plugin was unbuildable in the farm as it stood. The new optional cargo_package manifest field names the crate to build: validate_manifest.py validates it, the setup job carries it into the build matrix, and the cargo step adds --package from that env value when present. Entries that omit it build exactly as before. Tests cover both the validator and the workflow plumbing.

Promotion

• manifest.json: nu_plugin_charton 0.9.0, tag v0.9.0 at c36e794a3c5b03c53b033352b432daf0ad80e962, Nu >=0.116.0 <0.117.0 (the crate pins nu-plugin =0.116), x86_64-apple-darwin excluded per the Intel Mac EOL convention.
• docs/backlog.json: ELIGIBLE to INTAKE_PENDING with the promotion note.
• README pending-first-build list and roadmap plugin count (34) updated.

Gates verified locally

• Tag to commit: validate_manifest.py --only nu_plugin_charton --verify-upstream passes.
• cargo build --release --locked -p nu_plugin_charton succeeds on Linux x86_64.
• Nu 0.116.1 smoke against the locally built binary: plugin registers, 19 charton commands are exposed, and a bar chart over sample data renders a valid SVG.
• Repo checks pass: format_json, check_repo_consistency, check_workflows, and the full scripts unit suite.

Next after merge: dispatch build-plugins with only=nu_plugin_charton, then hand the emitted spec to numan-registry for intake and lifecycle-prove.

---

Summary by cubic

Promotes nu_plugin_charton 0.9.0 from wangjiawen2013/charton to the CI build farm, and adds an optional cargo_package manifest field so the build workflow can compile workspace-member plugin crates when the repo's default package is something else.

Why cargo_package exists

• The charton repo is a Cargo workspace whose root is the charton library; the plugin is a member crate (nu_plugin_charton), which the workflow previously couldn't build.
• New optional field names the crate to build; validate_manifest.py validates it, the setup job carries it into the matrix, and the build adds --package from the env value when present.
• Entries that omit it build exactly as before; tests cover the validator and workflow plumbing.

Promotion

• manifest.json gains the nu_plugin_charton 0.9.0 entry (tag v0.9.0, Nu >=0.116.0 <0.117.0, Intel Mac excluded).
• docs/backlog.json moves the entry from ELIGIBLE to INTAKE_PENDING; README and roadmap plugin count updated.
• Tag-to-commit check, locked build on Linux x86_64, Nu 0.116.1 smoke test, and repo checks all pass locally.

^{Written for commit 1ef3cfc. Summary will update on new commits.}

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	⚠️ Failed 2026-10-31T16:39:02.758554Z We couldn’t complete this review. Comment @codex review to try again.	1ef3cfc	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 050b60ca-9c2d-4f8a-948c-cf4821dd884f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

[amazon-q-developer]

Review Summary

This PR correctly introduces cargo_package support to enable building workspace-member Cargo crates in the CI farm, and promotes nu_plugin_charton 0.9.0 as its first user.

All changed components are correct and consistent with each other:

• validate_manifest.py: validate_cargo_package is correctly implemented and wired into validate_active_entry. The regex ^[A-Za-z0-9][A-Za-z0-9_-]*$ accepts valid Cargo package identifiers.
• build.yml: cargo_package is correctly propagated from the inline Python matrix-builder into each matrix leg's include entry, exposed as MATRIX_CARGO_PACKAGE through env: (never via direct shell interpolation), and conditionally appended to build_cmd before the --locked invocation. Critically, the --locked retry fallback also uses "${build_cmd[@]}" rather than a hardcoded cargo invocation — the workspace crate would otherwise be missing --package on the retry path.
• manifest.json: The nu_plugin_charton entry is well-formed with "cargo_package": "nu_plugin_charton", correct source_commit, tag, nu_version, and x86_64-apple-darwin exclusion per convention.
• scripts/test_validate_manifest.py: New tests cover acceptance of a valid selector and rejection of each invalid form ("", string with spaces, "foo/bar", integer).
• scripts/test_workflow_safety.py: test_build_plumbs_cargo_package_selection verifies all three structural invariants (matrix propagation, env wiring, build command injection) that must hold simultaneously for the feature to work correctly.

No merge-blocking defects found. The change is ready to merge.

---

You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

[opencode-agent]

No noteworthy issues found.

github run

[cubic-dev-ai]

No issues found across 8 files

Confidence score: 5/5

• Automated review surfaced no issues in the provided summaries.
• No files require special attention.

_{View guided diff | Re-trigger cubic}