Repository navigation
Feat/mirna target validation - #109
Merged
Merged
Conversation
Genarito
requested changes
Oct 7, 2026
| response = get_mirna_target_validation_action(self.request({})) | ||
| self.assertEqual(response.status_code, 400) | ||
|
|
||
| def test_only_accepts_get(self): |
Member
There was a problem hiding this comment.
Agregar docstrings explicando qué es lo que chequea cada test
| from django.contrib.auth import get_user_model | ||
|
|
||
|
|
||
| class MirnaTargetValidationQuerySerializer(serializers.Serializer): |
Member
There was a problem hiding this comment.
- Todo este serialzier debe ser
read_only - Por ende, también eliminar todo lo que es validate
- todo lo referente a paginación, filtros y ordenamiento debe ser implementado en la vista, como se hace con MiRNATargetInteractions
|
|
||
|
|
||
| @login_required | ||
| @require_http_methods(['GET']) |
Member
There was a problem hiding this comment.
Hacer igual que la vista de arriba. No debería ser más complejo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cambios
Verificación
npm.cmd run check-all(TypeScript y ESLint)api_service.tests.test_mirna_target_validationgit diff --check