Skip to content

Fixes 27292: Remove stale bot authentication TODOs - #34076

Open
Vamsi-klu wants to merge 4 commits into
open-metadata:mainfrom
Vamsi-klu:fix/27292-remove-stale-bot-todos
Open

Vamsi-klu wants to merge 4 commits into
open-metadata:mainfrom
Vamsi-klu:fix/27292-remove-stale-bot-todos

Conversation

@Vamsi-klu

@Vamsi-klu Vamsi-klu commented Sep 27, 2026 •

Copy link
Copy Markdown

Describe your changes:

Fixes #27292

Remove the two stale TODO remove this comments around
addAuthMechanismToBot in UserResource.

The method, its create and update call sites, and bot authentication behavior
remain unchanged.

Type of change:

  • Bug fix
  • Improvement
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

High-level design:

Not applicable. This is a comment-only cleanup with no executable-code,
configuration, schema, or API changes.

Tests:

Use cases covered

  • Verified that both stale TODO comments are removed.
  • Verified that both call sites and the addAuthMechanismToBot method remain unchanged.
  • Verified that the complete branch diff contains no executable-code changes.

Unit tests

Not applicable. Removing comments cannot change runtime behavior.

Backend integration tests

Not applicable. No API or executable-code behavior changed.

Ingestion integration tests

Not applicable. No ingestion code changed.

Playwright (UI) tests

Not applicable. No UI code changed.

Validation performed

  • Java formatting validation
  • OpenMetadata service Spotless check
  • git diff --check
  • Source-level acceptance checks for the removed comments and retained method usage

UI screen recording / screenshots:

Not applicable. No UI changes were made.

Checklist:

  • I have read the CONTRIBUTING document.
  • My PR title follows the required Fixes <issue-number>: <description> format.
  • The PR is linked to Fixes #27292.
  • Code comments: not applicable; no executable code was added.
  • JSON Schema migration: not applicable; no schema changes.
  • UI evidence: not applicable; no UI changes.
  • Tests: runtime tests are not applicable to this comment-only cleanup; formatting and source-level validations are documented above.

RetriggerView in GreptileConfidence Score: 5/5

This comment-only cleanup is safe to merge.

Summary

Removes two stale TODO comments around addAuthMechanismToBot in UserResource.java.

  • The bot-user flow no longer carries stale authentication TODOs.

Reviews (1) · Last reviewed commit: "Merge branch 'main' into fix/27292-remov..." · Reviewed by Greptile

@github-actions

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@Vamsi-klu
Vamsi-klu marked this pull request as ready for review September 27, 2026 02:48
@Vamsi-klu
Vamsi-klu requested a review from a team as a code owner September 27, 2026 02:48
@github-actions

github-actions Bot commented Sep 27, 2026 •

Copy link
Copy Markdown
Contributor

✅ PR checks passed

The linked issue has a description and all required Shipping project fields set. Thanks!

@harshach harshach added the safe to test Add this label to run secure Github workflows on PRs label Sep 27, 2026
@sonarqubecloud

Copy link
Copy Markdown

Copy link
Copy Markdown
Author

@open-metadata maintainers: The PR metadata check is blocked because linked issue #27292 is not in the Shipping project. Could someone with Shipping project edit access add the issue and set Status, Source, Priority, Domain, and Release, then rerun PR Metadata Validation? My account has read-only access to this repository and cannot edit the project. Thanks!

@github-actions github-actions Bot removed the safe to test Add this label to run secure Github workflows on PRs label Sep 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@gitar-bot

gitar-bot Bot commented Oct 17, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

🟢 Low risk · Removing two stale TODO comments in UserResource leaves bot authentication code and call sites unchanged, so runtime behavior and access decisions are unaffected.

Removes two stale TODO comments from addAuthMechanismToBot in UserResource with no changes to executable code or behavior. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

This branch was successfully deployed

1 active (outdated) deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Tech Debt] Clean up stale TODO comments in UserResource.java

3 participants