Skip to content

Fixes 27292: Remove stale bot authentication TODOs #34076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Vamsi-klu wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fixes 27292: Remove stale bot authentication TODOs #34076

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ecd4ec6
Fixes 27292: remove stale bot authentication TODOs
Vamsi-klu Sep 26, 2026
56ab7f1
Merge branch 'main' into fix/27292-remove-stale-bot-todos
harshach Sep 27, 2026
6c9ad85
Merge branch 'main' into fix/27292-remove-stale-bot-todos
mohityadav766 Oct 15, 2026
1685b61
Merge branch 'main' into fix/27292-remove-stale-bot-todos
Vamsi-klu Oct 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions ...metadata-service/src/main/java/org/openmetadata/service/resources/teams/UserResource.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2188,7 +2188,6 @@ && userHasRelationshipWithAnyBot(original, bot)) {
original.getAuthenticationMechanism());
user.setRoles(original.getRoles());
}
// TODO remove this -> Still valid TODO?
addAuthMechanismToBot(user, create, uriInfo);
addRolesToBot(user, uriInfo);
PutResponse<User> response =
Expand Down Expand Up @@ -2237,7 +2236,6 @@ private List<CollectionDAO.EntityRelationshipRecord> retrieveBotRelationshipsFor
return repository.findToRecords(bot.getId(), Entity.BOT, Relationship.CONTAINS, Entity.USER);
}

// TODO remove this -> still valid TODO?
private void addAuthMechanismToBot(User user, @Valid CreateUser create, UriInfo uriInfo) {
if (!Boolean.TRUE.equals(user.getIsBot())) {
throw new IllegalArgumentException(
Expand Down
Loading