Repository navigation
Fixes #34869: Platform Settings part 3 — Data Asset Rules, Learning Resources - #34888
Merged
chirag-madlani merged 2 commits intoOct 8, 2026
Conversation
Contributor
✅ PR checks passedThe linked issue has a description and all required Shipping project fields set. Thanks! |
github-actions
Bot
added
the
safe to test
Contributor
🔄 Playwright impact map auto-refreshedThis PR touched specs or UI source that changed the source→spec routing map. I regenerated What is this file? It is the auto-generated half of Playwright's PR planner. It routes "if source X changes, run specs Y" by walking spec imports and cross-referencing What if I want to regenerate locally instead? Run this before pushing your next change to skip the bot commit: python3 .github/scripts/generate_playwright_impact_map.py
git add .github/playwright/impact-map.generated.json
git commit --amend --no-edit # or a separate commit |
![gitar-bot[bot]](https://avatars.githubusercontent.com/in/827041?s=60&v=4){kind=small}
Contributor
Jest test CoverageUI tests summary
|
15 tasks done
chirag-madlani
force-pushed
the
chirag-madlani/ai-mode-settings-modal-pr2
branch
from
October 8, 2026 07:06
7fc58d0 to
8a57e98
Compare
chirag-madlani
force-pushed
the
chirag-madlani/ai-mode-settings-modal-pr3
branch
from
October 8, 2026 07:07
7dce727 to
b1a1a7e
Compare
ShaileshParmar11
approved these changes
Oct 8, 2026
chirag-madlani
force-pushed
the
chirag-madlani/ai-mode-settings-modal-pr2
branch
from
October 8, 2026 09:18
8a57e98 to
e73aeea
Compare
chirag-madlani
force-pushed
the
chirag-madlani/ai-mode-settings-modal-pr3
branch
from
October 8, 2026 09:18
b1a1a7e to
372c1eb
Compare
chirag-madlani
force-pushed
the
chirag-madlani/ai-mode-settings-modal-pr2
branch
from
October 8, 2026 10:49
e73aeea to
0496389
Compare
chirag-madlani
force-pushed
the
chirag-madlani/ai-mode-settings-modal-pr3
branch
from
October 8, 2026 10:49
372c1eb to
844c4f4
Compare
…esources Move the classic Settings > Preferences Data Asset Rules and Learning Resources pages into the AI-mode settings modal on ui-core-components. - Data Asset Rules: rule list with the in-place Enabled toggle. Adding rules is not supported yet, so the empty state has no Add. Marked Beta on the landing, as in the classic menu. - Learning Resources: the list (search, quick filters, table/card views, preview, delete) on the classic page's data hooks; the antd drawer form is replaced by a HookForm add/edit page (learning-resources/edit[/<id>]) that carries over fields it does not edit (difficulty, context componentId). The Learning Resources quick-filter row drops its last antd Space for a core Box, which the classic page shares. Also fixes two issues in the earlier parts: - useSettingsFetch loads once per mount. Under StrictMode its effect ran twice and the second response could reset a form the user had started editing. - The dimension edit form fetches only the dimensions, not the two count endpoints it never used. - Each page is keyed by its route, so moving between items (add -> edit, browser back/forward) remounts it and loads the right data. - Empty states centre in the content area instead of the whole modal.
chirag-madlani
force-pushed
the
chirag-madlani/ai-mode-settings-modal-pr2
branch
from
October 8, 2026 10:54
0496389 to
362e2b3
Compare
chirag-madlani
force-pushed
the
chirag-madlani/ai-mode-settings-modal-pr3
branch
from
October 8, 2026 10:54
844c4f4 to
3f71a7c
Compare
Code Review ✅ Approved 1 closed / 1 findings🔴 High risk · The new search settings can disable role and policy enforcement, potentially exposing search results for assets users are not permitted to access. Migrates Data Asset Rules and Learning Resources into Platform Settings with HookForm-based edit pages, comprehensive test coverage, and fixes including stale edit link handling that now returns to the list after an error. No issues found. ✅ 1 closed✅ Edge Case: Edit form stays on a skeleton forever when the resource fetch fails
OptionsDisplay: compact → Counting what did not apply, without listing it. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
Moves Settings > Preferences > Search into the AI-mode settings modal: the global search settings (access control, column indexing, limits, hybrid weights, term and field value boosts, reset) and one page per entity (ranking, matching fields, modes, boosts) with a live preview of the unsaved draft. Built on ui-core-components only. Platform Settings pages can now have read-only item sub-pages at <page>/<itemId>; header titles and breadcrumbs move into getPageHeader.
chirag-madlani
merged commit Oct 8, 2026
d4bc97c
into
chirag-madlani/ai-mode-settings-modal-pr2
54 of 55 checks passed
|
chirag-madlani
added a commit
that referenced
this pull request
Oct 8, 2026
…n, Data Quality (#34882) * Fixes #34868: Platform Settings part 2 — Theme, Profiler Configuration, Data Quality Move the classic Settings > Preferences Theme, Profiler Configuration and Data Quality pages into the AI-mode settings modal, each as a read-only view plus an edit form built on ui-core-components and HookForm. - Theme: logo/monogram/favicon URLs with live previews, eight free-form HEX colours (native swatch + text input), primary colour re-deriving hover and selected, and Reset. - Profiler Configuration: per-data-type metric rows on a field array with the "All" shortcut, the disable toggle, sample data settings, and the Collate Spark extension point. - Data Quality: dimension list with search, counts and read-only system rows; add/edit routes (data-quality/edit[/<name>]) and a delete confirmation that reports affected test cases and definitions. Routing gains an optional item id and a per-page edit title so list pages can host add/edit forms. * Fixes #34869: Platform Settings part 3 — Data Asset Rules, Learning Resources (#34888) Move the classic Settings > Preferences Data Asset Rules and Learning Resources pages into the AI-mode settings modal on ui-core-components. - Data Asset Rules: rule list with the in-place Enabled toggle. Adding rules is not supported yet, so the empty state has no Add. Marked Beta on the landing, as in the classic menu. - Learning Resources: the list (search, quick filters, table/card views, preview, delete) on the classic page's data hooks; the antd drawer form is replaced by a HookForm add/edit page (learning-resources/edit[/<id>]) that carries over fields it does not edit (difficulty, context componentId). The Learning Resources quick-filter row drops its last antd Space for a core Box, which the classic page shares. Also fixes two issues in the earlier parts: - useSettingsFetch loads once per mount. Under StrictMode its effect ran twice and the second response could reset a form the user had started editing. - The dimension edit form fetches only the dimensions, not the two count endpoints it never used. - Each page is keyed by its route, so moving between items (add -> edit, browser back/forward) remounts it and loads the right data. - Empty states centre in the content area instead of the whole modal. * Keep busy Platform Settings dialogs open until their request finishes The delete-dimension, confirmation and test-email dialogs blocked outside clicks while busy, but the close button and Escape still dismissed them, so the request kept running behind a dialog that looked cancelled. While busy, the close button is hidden and Escape is ignored.
timothybrush
pushed a commit
to timothybrush/OpenMetadata
that referenced
this pull request
Oct 8, 2026
…de settings modal (Platform Settings, part 1) (open-metadata#34872) * Fixes open-metadata#34867: Move Settings > Preferences into the AI-mode settings modal (Platform Settings, part 1) Add an admin-only Administration > Platform Settings section to the AI-mode settings modal: a landing of cards with hash routing, and a read-only view plus edit form for Email (with Test Email), Login Configuration, Health Check, Lineage, OpenMetadata URL and Default App Mode. Built only with ui-core-components; forms use HookForm and take their field hints from the same per-form docs markdown the classic doc panel reads. The classic /settings/preferences pages are untouched. The section/row layout is extracted from ProfileDetailsPanel into SettingsSection so both share it, and the Playwright impact map gains entries for the new folder and the modal shell. * Fixes open-metadata#34868: Platform Settings part 2 — Theme, Profiler Configuration, Data Quality (open-metadata#34882) * Fixes open-metadata#34868: Platform Settings part 2 — Theme, Profiler Configuration, Data Quality Move the classic Settings > Preferences Theme, Profiler Configuration and Data Quality pages into the AI-mode settings modal, each as a read-only view plus an edit form built on ui-core-components and HookForm. - Theme: logo/monogram/favicon URLs with live previews, eight free-form HEX colours (native swatch + text input), primary colour re-deriving hover and selected, and Reset. - Profiler Configuration: per-data-type metric rows on a field array with the "All" shortcut, the disable toggle, sample data settings, and the Collate Spark extension point. - Data Quality: dimension list with search, counts and read-only system rows; add/edit routes (data-quality/edit[/<name>]) and a delete confirmation that reports affected test cases and definitions. Routing gains an optional item id and a per-page edit title so list pages can host add/edit forms. * Fixes open-metadata#34869: Platform Settings part 3 — Data Asset Rules, Learning Resources (open-metadata#34888) Move the classic Settings > Preferences Data Asset Rules and Learning Resources pages into the AI-mode settings modal on ui-core-components. - Data Asset Rules: rule list with the in-place Enabled toggle. Adding rules is not supported yet, so the empty state has no Add. Marked Beta on the landing, as in the classic menu. - Learning Resources: the list (search, quick filters, table/card views, preview, delete) on the classic page's data hooks; the antd drawer form is replaced by a HookForm add/edit page (learning-resources/edit[/<id>]) that carries over fields it does not edit (difficulty, context componentId). The Learning Resources quick-filter row drops its last antd Space for a core Box, which the classic page shares. Also fixes two issues in the earlier parts: - useSettingsFetch loads once per mount. Under StrictMode its effect ran twice and the second response could reset a form the user had started editing. - The dimension edit form fetches only the dimensions, not the two count endpoints it never used. - Each page is keyed by its route, so moving between items (add -> edit, browser back/forward) remounts it and loads the right data. - Empty states centre in the content area instead of the whole modal. * Keep busy Platform Settings dialogs open until their request finishes The delete-dimension, confirmation and test-email dialogs blocked outside clicks while busy, but the close button and Escape still dismissed them, so the request kept running behind a dialog that looked cancelled. While busy, the close button is hidden and Escape is ignored. * Report a Search reset as successful only when the reload works Resetting the global settings or restoring an entity's defaults showed a success toast even when the reload after it failed, next to the reload's error toast, while the page kept the old settings. fetchConfig now reports whether it loaded, and the success toast waits for it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes:
Fixes #34869
Moves the last two non-search classic Settings → Preferences pages into the AI-mode settings modal's Platform Settings: Data Asset Rules and Learning Resources. Platform Settings now covers 11 of the 12 legacy pages; Search follows in #34870. The new UI is built only from
@openmetadata/ui-core-components, and forms useHookForm. The classic pages are untouched apart from one shared filter row (see below).Type of change:
High-level design:
Builds on the Platform Settings panel from parts 1–2: the page registry, hash routing, view + edit pages and
itemIdroutes.Data Asset Rules (
DataAssetRulesSettings)Tableof rules (name, description, Enabled). Toggling saves the rule list through the existinguseSemanticsRulesStatehook, the same call the classic page makes.Learning Resources (
LearningResourcesSettings,LearningResourceSettingsForm,LearningResourceSettings.utils)useLearningResources,useLearningResourceFilters,useLearningResourceActions) plus the existing core-based player, card, view toggle and delete modal. So search, quick filters, table/card views, preview and delete behave as before. Add Resource sits in the modal header.Drawer+Formis replaced by aHookFormpage at#platform-settings/learning-resources/edit[/<id>].componentId) are carried over on update rather than dropped.useLearningResourceFiltersdrops its last antdSpacefor a coreBox. The classic page shares that hook; it renders the same, and its tests pass.Fixes to the earlier parts (included here; they touch code from #34872/#34882):
useSettingsFetchloads once per mount. Under StrictMode its effect ran twice. The second response could arrive after the user started typing andform.resetwould wipe the edit. This made the Data Quality E2E flaky.SettingsFormSection's title is now optional; the resource form omits it because the page header already names it.useLearningResourceFiltersdrops a redundantuseMemodependency, and the selected filter value uses the theme-adaptingtw:text-brand-secondaryinstead of the statictw:text-brand-600.Tests:
Use cases covered
data-asset-rules/edithas no form route.componentId/difficulty.Unit tests
DataAssetRulesSettings.test.tsx,LearningResourcesSettings.test.tsx; updatedPlatformSettingsPanel.test.tsx.Backend integration tests
Ingestion integration tests
Playwright (UI) tests
playwright/e2e/Features/ProfilePlatformSettings.spec.tsto 16 tests:test.slow().Local run against a dev server (
PLAYWRIGHT_IS_OSS=true, local backend on :8585):Features/ProfilePlatformSettings.spec.tsManual testing performed
UI screen recording / screenshots:
Recording (
platform-settings-pr3-walkthrough.mp4, 44s) and screenshots to be attached.Checklist:
I have read the CONTRIBUTING document.
My PR title is
Fixes <issue-number>: <short explanation>My PR is linked to a GitHub issue via
Fixes #<issue-number>above.I have commented on my code, particularly in hard-to-understand areas.
For JSON Schema changes: Not applicable — no schema changes.
For UI changes: I attached a screen recording and/or screenshots above.
I have added tests (unit / integration / Playwright as applicable) and listed them above.
The issue properly describes why the new feature is needed, what's the goal, and how we are building it.
I have updated the documentation. Not applicable — UI move; no user-facing docs change.
I have added tests around the new logic.
🤖 Generated with Claude Code