Skip to content

test(playwright): move AI sidebar persona customization spec from Collate - #35659

Closed
karanh37 wants to merge 1 commit into
mainfrom
karanh37/askcollate-playwright-move
Closed

karanh37 wants to merge 1 commit into
mainfrom
karanh37/askcollate-playwright-move

Conversation

@karanh37

@karanh37 karanh37 commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Describe your changes:

The AI app-mode sidebar (ai-shell/Sidebar) and its persona customize page (/customize-page/:persona/askCollateSidebar) are now OSS layout, but their E2E coverage lived in Collate (AskCollateSidebarPersonaCustomization.spec.ts). This moves that spec into OSS as Features/AIMode/AppModeSidebarPersonaCustomization.spec.ts; the Collate copy is deleted in a companion Collate PR.

Adapted to OSS:

  • Hide an item — admin hides Explore in the editor; the persona's live sidebar drops Explore, Home stays. (The Collate "New Chat cannot be hidden" step is Collate-only, no chat module in OSS.)
  • Default layout — the persona sidebar shows the OSS modules in navOrder (home, explore, lineage, connections, observability, govern, marketplace, context-center), with no More trigger. All of them fit in the visible slice of 10, so OSS ships an empty More group.
  • Hide More — OSS has nothing under More by default, so the test seeds a layout with Context Center under More (listing every item, since the editor treats unlisted items as hidden), checks it's reachable from the More popover, then hides More in the editor and checks that the trigger and Context Center are both gone.

Uses the shared adminPage role fixture, sets up the persona and user through the worker admin API context, and gives each test its own persona so the tests stay independent and can run in parallel. impact-map.generated.json is regenerated (--check passes).

Type of change:

  • Improvement

Tests:

Playwright (UI) tests

  • Added playwright/e2e/Features/AIMode/AppModeSidebarPersonaCustomization.spec.ts
  • Local run: this branch's UI served by Vite against a local backend, --project=chromium --repeat-each=2 --workers=3 → 6 passed. yarn lint:playwright → 0 errors.

Manual testing performed

N/A — test-only change.

UI screen recording:

Not applicable — test-only change, no UI behaviour change.

Checklist:

  • I have read the CONTRIBUTING document.
  • I have added tests around the new logic.

RetriggerView in GreptileConfidence Score: 4/5

The PR appears safe to merge, with a non-blocking cleanup gap in the new tests.

Findings

  1. P2 Saved test layouts remain ▶

Summary

Adds OSS Playwright coverage for persona-specific AI sidebar layouts.

  • Playwright checks persona sidebar customization in OSS.

Reviews (1) · Last reviewed commit: "test(playwright): move AI sidebar person..." · Reviewed by Greptile

…late

The app-mode sidebar and its persona customize page now live in OSS, so the
spec that covered them moves here from Collate. Assertions are adapted to the
OSS module set: no New Chat item, and every default module fits in the
visible slice, so the More-node test seeds a layout with Context Center under
More before hiding it.
Copilot AI balanced review requested due to automatic review settings October 16, 2026 13:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Oct 16, 2026
@gitar-bot

gitar-bot Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Code Review ✅ Approved

🟢 Low risk · Adding Playwright coverage and test-only persona/layout setup exercises sidebar customization without changing production behavior or interfaces.

Moves the AI app-mode sidebar persona customization E2E spec from Collate into OSS as Features/AIMode/AppModeSidebarPersonaCustomization.spec.ts, covering hiding an item, the default OSS sidebar layout, and hiding the More group. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

Comment on lines +78 to +79
await user.delete(apiContext);
await persona.delete(apiContext);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Saved test layouts remain

The two tests that save a layout leave their docStore documents behind. This teardown deletes only the user and persona; deleting a persona does not delete its layout document. Repeated runs therefore leave unused layouts in the test backend. Track each document or fetch it by its persona FQN, then hard-delete it during teardown.

@anuj-kumary

Copy link
Copy Markdown
Member

Closing this as the changes have already been addressed in #35677.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants