Repository navigation
Conversation
…late The app-mode sidebar and its persona customize page now live in OSS, so the spec that covered them moves here from Collate. Assertions are adapted to the OSS module set: no New Chat item, and every default module fits in the visible slice, so the More-node test seeds a layout with Context Center under More before hiding it.
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
Code Review ✅ Approved🟢 Low risk · Adding Playwright coverage and test-only persona/layout setup exercises sidebar customization without changing production behavior or interfaces. Moves the AI app-mode sidebar persona customization E2E spec from Collate into OSS as VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Not enabledFor more verification details, comment OptionsDisplay: compact → Showing compact verification results. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
| await user.delete(apiContext); | ||
| await persona.delete(apiContext); |
There was a problem hiding this comment.
The two tests that save a layout leave their docStore documents behind. This teardown deletes only the user and persona; deleting a persona does not delete its layout document. Repeated runs therefore leave unused layouts in the test backend. Track each document or fetch it by its persona FQN, then hard-delete it during teardown.
|
Closing this as the changes have already been addressed in #35677. |
Describe your changes:
The AI app-mode sidebar (
ai-shell/Sidebar) and its persona customize page (/customize-page/:persona/askCollateSidebar) are now OSS layout, but their E2E coverage lived in Collate (AskCollateSidebarPersonaCustomization.spec.ts). This moves that spec into OSS asFeatures/AIMode/AppModeSidebarPersonaCustomization.spec.ts; the Collate copy is deleted in a companion Collate PR.Adapted to OSS:
navOrder(home, explore, lineage, connections, observability, govern, marketplace, context-center), with no More trigger. All of them fit in the visible slice of 10, so OSS ships an empty More group.Uses the shared
adminPagerole fixture, sets up the persona and user through the worker admin API context, and gives each test its own persona so the tests stay independent and can run in parallel.impact-map.generated.jsonis regenerated (--checkpasses).Type of change:
Tests:
Playwright (UI) tests
playwright/e2e/Features/AIMode/AppModeSidebarPersonaCustomization.spec.ts--project=chromium --repeat-each=2 --workers=3→ 6 passed.yarn lint:playwright→ 0 errors.Manual testing performed
N/A — test-only change.
UI screen recording:
Not applicable — test-only change, no UI behaviour change.
Checklist:
The PR appears safe to merge, with a non-blocking cleanup gap in the new tests.
Findings
Summary
Adds OSS Playwright coverage for persona-specific AI sidebar layouts.
Reviews (1) · Last reviewed commit: "test(playwright): move AI sidebar person..." · Reviewed by Greptile