Skip to content

test(playwright): move AI sidebar persona customization spec from Collate - #35677

Merged
anuj-kumary merged 4 commits into
mainfrom
anuj-kumary/openmetadata-pr-cmake
Oct 17, 2026
Merged

anuj-kumary merged 4 commits into
mainfrom
anuj-kumary/openmetadata-pr-cmake

Conversation

@anuj-kumary

@anuj-kumary anuj-kumary commented Oct 17, 2026 •

Copy link
Copy Markdown
Member

Describe your changes:

Carries over #35659. The AI app-mode sidebar (ai-shell/Sidebar) and its persona customize page (/customize-page/:persona/askCollateSidebar) are now OSS layout, so this moves their E2E coverage from Collate into OSS as Features/AIMode/AppModeSidebarPersonaCustomization.spec.ts. The spec covers three cases: hiding an item removes it from the persona's live sidebar; the default persona sidebar shows the OSS modules in navOrder with no More trigger; and hiding the More node removes both the trigger and its items. Each test seeds its own persona and user through the worker admin API context, so the tests run independently and in parallel. impact-map.generated.json is regenerated.

Type of change:

  • Improvement

High-level design:

N/A — test-only change.

Tests:

Playwright (UI) tests

  • Added playwright/e2e/Features/AIMode/AppModeSidebarPersonaCustomization.spec.ts
  • ESLint: 0 errors (1 expected browser.newPage() warning for the second, non-admin user page). Prettier: clean.
  • Local run of the new spec only, PR UI (d4edc312c08) on Vite against a server built from the same commit (fresh MySQL + ES, docker/development stack):
    PLAYWRIGHT_IS_OSS=true PLAYWRIGHT_TEST_BASE_URL=http://localhost:3000 \
      npx playwright test playwright/e2e/Features/AIMode/AppModeSidebarPersonaCustomization.spec.ts \
      --project=chromium --repeat-each=2 --workers=3
    
    → 9 passed (1.2m): 6/6 spec tests across 2 repeats, plus auth setup and entity-data setup/teardown.
    • ✅ hiding an item removes it from that persona's live sidebar (×2)
    • ✅ the default persona sidebar shows every default item visible in order with no More trigger (×2)
    • ✅ hiding the More node removes the overflow trigger from the live sidebar (×2)
  • Other impact-mapped specs were not run locally; they run in the merge queue.

Manual testing performed

N/A — test-only change.

UI screen recording:

Not applicable — test-only change, no UI behaviour change.

Checklist:

  • I have read the CONTRIBUTING document.
  • I have added tests (unit / integration / Playwright as applicable) and listed them above.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; both previous findings are fixed and no new actionable issues remain.

Summary

Adds three Playwright tests for persona sidebar customization in OSS:

  • OSS Playwright tests check persona sidebar visibility and overflow behavior.

Both previous findings are fixed. The latest changes add the missing test mapping and install server-load reducers before the custom user signs in. No new actionable issues were found.

Reviews (2) · Last reviewed commit: "Merge remote-tracking branch 'origin/anu..." · Reviewed by Greptile

…late

The app-mode sidebar and its persona customize page now live in OSS, so the
spec that covered them moves here from Collate. Assertions are adapted to the
OSS module set: no New Chat item, and every default module fits in the
visible slice, so the More-node test seeds a layout with Context Center under
More before hiding it.
@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@anuj-kumary anuj-kumary self-assigned this Oct 17, 2026
@github-actions github-actions Bot added the UI UI specific issues label Oct 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@anuj-kumary anuj-kumary added safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check labels Oct 17, 2026
Comment thread .github/playwright/impact-map.generated.json
@anuj-kumary
anuj-kumary enabled auto-merge October 17, 2026 08:31
@gitar-bot

gitar-bot Bot commented Oct 17, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

🟢 Low risk · Adds isolated Playwright coverage and impact-map selection; changes only test execution and does not alter application runtime behavior.

Moves the AI app-mode sidebar persona customization E2E spec from Collate into OSS as Features/AIMode/AppModeSidebarPersonaCustomization.spec.ts, covering hiding items, default persona navOrder, and hiding the More node. No open issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@anuj-kumary
anuj-kumary added this pull request to the merge queue Oct 17, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🚦 Removed from the merge queue — failed_checks (2026-10-17T09:33:54Z)

Blocked the queue: playwright-summary

Failed Playwright tests:

  • Features/TeamsHierarchy.spec.ts › Only Group teams are selectable in user profile teams edit

@anuj-kumary
anuj-kumary added this pull request to the merge queue Oct 17, 2026
Merged via the queue into main with commit 5856c84 Oct 17, 2026
87 of 88 checks passed
@anuj-kumary
anuj-kumary deleted the anuj-kumary/openmetadata-pr-cmake branch October 17, 2026 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs skip-pr-checks Bypass PR metadata validation check UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants