Repository navigation
test(playwright): move AI sidebar persona customization spec from Collate - #35677
Conversation
…late The app-mode sidebar and its persona customize page now live in OSS, so the spec that covered them moves here from Collate. Assertions are adapted to the OSS module set: no New Chat item, and every default module fits in the visible slice, so the More-node test seeds a layout with Context Center under More before hiding it.
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
…e' into anuj-kumary/openmetadata-pr-cmake
Code Review ✅ Approved🟢 Low risk · Adds isolated Playwright coverage and impact-map selection; changes only test execution and does not alter application runtime behavior. Moves the AI app-mode sidebar persona customization E2E spec from Collate into OSS as VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Not enabledFor more verification details, comment OptionsDisplay: compact → Showing compact verification results. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
🚦 Removed from the merge queue —
|
Describe your changes:
Carries over #35659. The AI app-mode sidebar (
ai-shell/Sidebar) and its persona customize page (/customize-page/:persona/askCollateSidebar) are now OSS layout, so this moves their E2E coverage from Collate into OSS asFeatures/AIMode/AppModeSidebarPersonaCustomization.spec.ts. The spec covers three cases: hiding an item removes it from the persona's live sidebar; the default persona sidebar shows the OSS modules innavOrderwith no More trigger; and hiding the More node removes both the trigger and its items. Each test seeds its own persona and user through the worker admin API context, so the tests run independently and in parallel.impact-map.generated.jsonis regenerated.Type of change:
High-level design:
N/A — test-only change.
Tests:
Playwright (UI) tests
playwright/e2e/Features/AIMode/AppModeSidebarPersonaCustomization.spec.tsbrowser.newPage()warning for the second, non-admin user page). Prettier: clean.d4edc312c08) on Vite against a server built from the same commit (fresh MySQL + ES,docker/developmentstack):Manual testing performed
N/A — test-only change.
UI screen recording:
Not applicable — test-only change, no UI behaviour change.
Checklist:
🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; both previous findings are fixed and no new actionable issues remain.Summary
Adds three Playwright tests for persona sidebar customization in OSS:
Both previous findings are fixed. The latest changes add the missing test mapping and install server-load reducers before the custom user signs in. No new actionable issues were found.
Reviews (2) · Last reviewed commit: "Merge remote-tracking branch 'origin/anu..." · Reviewed by Greptile