Skip to content

Run lineage entity matrices for one representative entity on PR CI - #35678

Queued
chirag-madlani wants to merge 2 commits into
mainfrom
lineage-representative-matrix
Queued

chirag-madlani wants to merge 2 commits into
mainfrom
lineage-representative-matrix

Conversation

@chirag-madlani

@chirag-madlani chirag-madlani commented Oct 17, 2026 •

Copy link
Copy Markdown
Collaborator

Describe your changes:

Lineage specs repeated heavy per-entity scenarios on every PR. This applies the same pickEntityMatrix treatment Entity.spec.ts uses: PR and merge-queue CI (PW_ENTITY_MATRIX=representative) run one representative entity; nightly, local runs, and PRs that edit the spec directly keep the full matrix.

  • DataAssetLineage.spec.ts › Column Level Lineage: the source was already Table-only on CI, but it still ran against all 8 targets. CI now runs two targets — Table (column-menu path, isColumnMenuTarget) and Dashboard (API path, addColumnLineageViaAPI) — and beforeAll only creates those targets.
  • LineageRightPanel.spec.ts: custom-properties tab visibility runs for Table only on CI, instead of 10 entity types.
Selection (--list) Column-lineage tests Both specs
PR / merge queue (representative) 2 16
Nightly / local / spec edited in PR 64 115

Why: merge-queue run 38898429973 had three lineage flakes on shard chromium-03 (Column lineage for table -> searchIndex, table -> dashboard, LineageFilters › Owners filter). The failure screenshots show Elasticsearch rejecting searches with 429 circuit_breaking_exception (parent breaker at 1.8 GB). Fewer heavy column-lineage runs per shard lowers that pressure; the breaker itself is an infra limit (ES_JAVA_OPTS 2g in docker-compose-playwright-fast.yml) and is not changed here.

Test titles are unchanged, so shard timing history stays keyed correctly.

Testing

Local run against a fresh stack (CI=true PW_ENTITY_MATRIX=representative PLAYWRIGHT_RETRIES=0), rebased on 2d95c1a1b9a:

16 passed (4.6m)

Note: this PR edits both specs, so its own CI run uses the full matrix (PW_DIRECT_CHANGED_SPECS).

Type of change:

  • Improvement

Checklist:

  • I have read the CONTRIBUTING document.
  • I have commented on my code, particularly in hard-to-understand areas.
  • I have added a test that covers the exact scenario we are fixing.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

Uses pickEntityMatrix to reduce repeated lineage tests in PR and merge-queue CI.

  • Column-lineage tests cover two targets in representative CI.
  • Custom-properties checks use Table in representative CI.

No actionable issues found. Tests were not run during this review.

Reviews (1) · Last reviewed commit: "chore(playwright): auto-refresh impact-m..." · Reviewed by Greptile

DataAssetLineage's column-level tests ran Table against all 8 targets on
every PR, and LineageRightPanel checked 10 entity types. PR and merge-queue
CI now run Table -> Table (column-menu path) and Table -> Dashboard (API
path), and Table only for the right panel; nightly and direct edits to the
spec keep the full matrix via pickEntityMatrix.
Copilot AI balanced review requested due to automatic review settings October 17, 2026 08:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions

Copy link
Copy Markdown
Contributor

❌ PR checklist incomplete

This PR cannot be merged until the following are addressed on its linked issue:

  • No GitHub issue is linked. Link an issue in the Development section of the PR (or add Fixes #12345 to the description). For a same-org cross-repo issue, add Fixes open-metadata/<repo>#123 to the description.

The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically.

Maintainers can bypass this check by adding the skip-pr-checks label.

@github-actions github-actions Bot added safe to test Add this label to run secure Github workflows on PRs UI UI specific issues labels Oct 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔄 Playwright impact map auto-refreshed

This PR touched specs or UI source that changed the source→spec routing map. I regenerated .github/playwright/impact-map.generated.json and pushed the diff to this branch.

- source entries: 933 → 933
- 0 added, 0 removed, 1 changed spec-list

Entries whose spec list changed:
  openmetadata-ui/src/main/resources/ui/playwright/utils/entityMatrix.ts

What is this file? It is the auto-generated half of Playwright's PR planner. It routes "if source X changes, run specs Y" by walking spec imports and cross-referencing getByTestId strings. Hand-authored routing in impact-map.json always wins on conflict.

What if I want to regenerate locally instead? Run this before pushing your next change to skip the bot commit:

python3 .github/scripts/generate_playwright_impact_map.py
git add .github/playwright/impact-map.generated.json
git commit --amend --no-edit  # or a separate commit

Copilot AI balanced review requested due to automatic review settings October 17, 2026 08:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@gitar-bot

gitar-bot Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Code Review ✅ Approved

🟡 Medium risk · Restricting PR lineage matrices to representative entities could let regressions specific to omitted entity types escape routine CI detection.

Restricts lineage Playwright matrices on PR CI to one representative entity by applying the pickEntityMatrix pattern, reducing column-lineage runs from 8 targets to 2 (Table and Dashboard) and custom-properties tab checks to Table only. Nightly and local runs keep the full matrix. No issues found.

Verification

Rules No rules evaluated

Functional validation Not enabled

Set up

Auto-approval Not enabled

Set up

For more verification details, comment gitar display:verbose.

Options

Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source

@chirag-madlani
chirag-madlani added this pull request to the merge queue Oct 17, 2026
Any commits made after this event will not be merged.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs UI UI specific issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants