Repository navigation
Run lineage entity matrices for one representative entity on PR CI - #35678
chirag-madlani wants to merge 2 commits into
Conversation
DataAssetLineage's column-level tests ran Table against all 8 targets on every PR, and LineageRightPanel checked 10 entity types. PR and merge-queue CI now run Table -> Table (column-menu path) and Table -> Dashboard (API path), and Table only for the right panel; nightly and direct edits to the spec keep the full matrix via pickEntityMatrix.
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
🔄 Playwright impact map auto-refreshedThis PR touched specs or UI source that changed the source→spec routing map. I regenerated What is this file? It is the auto-generated half of Playwright's PR planner. It routes "if source X changes, run specs Y" by walking spec imports and cross-referencing What if I want to regenerate locally instead? Run this before pushing your next change to skip the bot commit: python3 .github/scripts/generate_playwright_impact_map.py
git add .github/playwright/impact-map.generated.json
git commit --amend --no-edit # or a separate commit |
Code Review ✅ Approved🟡 Medium risk · Restricting PR lineage matrices to representative entities could let regressions specific to omitted entity types escape routine CI detection. Restricts lineage Playwright matrices on PR CI to one representative entity by applying the VerificationRules No rules evaluated Functional validation Not enabledAuto-approval Not enabledFor more verification details, comment OptionsDisplay: compact → Showing compact verification results. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
Describe your changes:
Lineage specs repeated heavy per-entity scenarios on every PR. This applies the same
pickEntityMatrixtreatmentEntity.spec.tsuses: PR and merge-queue CI (PW_ENTITY_MATRIX=representative) run one representative entity; nightly, local runs, and PRs that edit the spec directly keep the full matrix.DataAssetLineage.spec.ts› Column Level Lineage: the source was already Table-only on CI, but it still ran against all 8 targets. CI now runs two targets — Table (column-menu path,isColumnMenuTarget) and Dashboard (API path,addColumnLineageViaAPI) — andbeforeAllonly creates those targets.LineageRightPanel.spec.ts: custom-properties tab visibility runs for Table only on CI, instead of 10 entity types.--list)representative)Why: merge-queue run 38898429973 had three lineage flakes on shard
chromium-03(Column lineage for table -> searchIndex,table -> dashboard,LineageFilters › Owners filter). The failure screenshots show Elasticsearch rejecting searches with429 circuit_breaking_exception(parent breaker at 1.8 GB). Fewer heavy column-lineage runs per shard lowers that pressure; the breaker itself is an infra limit (ES_JAVA_OPTS2g indocker-compose-playwright-fast.yml) and is not changed here.Test titles are unchanged, so shard timing history stays keyed correctly.
Testing
Local run against a fresh stack (
CI=true PW_ENTITY_MATRIX=representative PLAYWRIGHT_RETRIES=0), rebased on2d95c1a1b9a:Note: this PR edits both specs, so its own CI run uses the full matrix (
PW_DIRECT_CHANGED_SPECS).Type of change:
Checklist:
🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge.Summary
Uses
pickEntityMatrixto reduce repeated lineage tests in PR and merge-queue CI.No actionable issues found. Tests were not run during this review.
Reviews (1) · Last reviewed commit: "chore(playwright): auto-refresh impact-m..." · Reviewed by Greptile