Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/playwright/impact-map.generated.json
Original file line number Diff line number Diff line change
Expand Up @@ -4309,6 +4309,7 @@
"playwright/e2e/Pages/ExplorePageRightPanel.spec.ts",
"playwright/e2e/Pages/Lineage/DataAssetLineage.spec.ts",
"playwright/e2e/Pages/Lineage/LineageLargeResponse.spec.ts",
"playwright/e2e/Pages/Lineage/LineageRightPanel.spec.ts",
"playwright/e2e/Pages/ServiceEntity.spec.ts",
"playwright/e2e/Pages/TasksUIFlow.spec.ts",
"playwright/e2e/Pages/Users.spec.ts",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,14 @@ const columnLevelEntities = {
searchIndex: SearchIndexClass,
mlModel: MlModelClass,
};
const columnLevelSources = pickEntityMatrix(__filename, columnLevelEntities, {
table: TableClass,
});
// Table covers the column-menu path, Dashboard the API path.
const columnLevelTargets = pickEntityMatrix(__filename, columnLevelEntities, {
table: TableClass,
dashboard: DashboardClass,
});

type EntityClassUnion =
| TableClass
Expand Down Expand Up @@ -316,7 +324,7 @@ test.describe('Column Level Lineage', () => {
browser
);

Object.entries(columnLevelEntities).forEach(([key, EntityClass]) => {
Object.entries(columnLevelTargets).forEach(([key, EntityClass]) => {
const lineageEntity = new EntityClass();

entities.set(key, lineageEntity);
Expand All @@ -334,12 +342,8 @@ test.describe('Column Level Lineage', () => {
await authenticateAdminPage(page);
});

Object.entries(
pickEntityMatrix(__filename, columnLevelEntities, { table: TableClass })
).forEach(([key, EntityClassSource]) => {
const entityKeys = Object.keys(columnLevelEntities);

entityKeys.forEach((targetKey) => {
Object.entries(columnLevelSources).forEach(([key, EntityClassSource]) => {
Object.keys(columnLevelTargets).forEach((targetKey) => {
test(`Column lineage for ${key} -> ${targetKey}`, async ({ page }) => {
test.slow();
const sourceEntity = new EntityClassSource();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ import {
getDefaultAdminAPIContext,
redirectToHomePage,
} from '../../../utils/common';
import { pickEntityMatrix } from '../../../utils/entityMatrix';
import {
clickLineageNode,
dismissLineageMapOnboarding,
Expand All @@ -39,7 +40,7 @@ test.describe(
() => {
test.describe.configure({ mode: 'default' });

const supportedEntities = [
const allSupportedEntities = [
{ entity: new TableClass(), type: 'table' },
{ entity: new TopicClass(), type: 'topic' },
{ entity: new DashboardClass(), type: 'dashboard' },
Expand All @@ -51,6 +52,11 @@ test.describe(
{ entity: new MetricClass(), type: 'metric' },
{ entity: new ChartClass(), type: 'chart' },
];
const supportedEntities = pickEntityMatrix(
__filename,
allSupportedEntities,
allSupportedEntities.filter(({ type }) => type === 'table')
);

test.beforeAll(async ({ browser }) => {
const { apiContext, afterAction } = await getDefaultAdminAPIContext(
Expand Down
Loading