You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
include the validation epoch in the scalar payload when log_metric_by_epoch=True
add regression coverage for the epoch-based validation logging path
This lets visualization backends such as WandbVisBackend define an epoch-based x-axis from the emitted scalar metadata. The scalar step remains unchanged.
CI note: the ci/circleci: lint failure on this PR is not caused by this patch.
ci/circleci: lint is currently red on every open PR in this repository — #1696, #1699 and #1700 all fail the same job. I verified this patch against the exact recipe in .circleci/test.yml locally instead:
pre-commit run --all-files → all 17 hooks passed (flake8, isort, yapf, mypy, docformatter, pyupgrade, mdformat, check-copyright, …)
pytest tests/test_runner/test_runner.py -k "test_train or after_val_epoch" → passing
branch base is identical to main; no config drift
The lint job runs pip install pre-commit (unpinned) on the cimg/python:3.7.4 image, so this looks like upstream CI breakage rather than anything in individual diffs. #1683 ("Update pre-commit config to fix CI failure") was opened in January to address it and was closed unmerged.
Happy to rebase onto a newer main or adjust the patch if there is feedback on the approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
log_metric_by_epoch=TrueThis lets visualization backends such as
WandbVisBackenddefine an epoch-based x-axis from the emitted scalar metadata. The scalar step remains unchanged.Fixes #1692.
Validation
pytest tests/test_hooks/test_logger_hook.py -q→ 7 passedgit diff --check→ passedThe focused test run emitted existing PyTorch deprecation warnings only.