Skip to content

Fix validation epoch metadata for visual backends #1693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dgexplores wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix validation epoch metadata for visual backends #1693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82f26bc
Fix validation epoch metadata for visual backends
dgexplores Aug 14, 2026
b3cb695
Add validation epoch logging regression test
dgexplores Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions mmengine/hooks/logger_hook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,7 @@ def after_val_epoch(self,
epoch = 0
else:
epoch = runner.epoch
tag['epoch'] = epoch
runner.visualizer.add_scalars(
tag, step=epoch, file_path=self.json_log_path)
else:
Expand Down
8 changes: 6 additions & 2 deletions tests/test_hooks/test_logger_hook.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,8 @@ def test_after_train_iter(self):
def test_after_val_epoch(self):
logger_hook = LoggerHook()
runner = MagicMock()
runner._train_loop = object()
runner.epoch = 3
# Test when `log_metric_by_epoch` is True
runner.log_processor.get_log_after_epoch = MagicMock(
return_value=({
Expand All @@ -135,7 +137,8 @@ def test_after_val_epoch(self):
call({
'time': 1,
'datatime': 1,
'acc': 0.8
'acc': 0.8,
'epoch': 3
}, **args),
]
self.assertEqual(
Expand All @@ -157,7 +160,8 @@ def test_after_val_epoch(self):
call({
'time': 1,
'datatime': 1,
'acc': 0.8
'acc': 0.8,
'epoch': 3
}, **args),
call({
'time': 5,
Expand Down