Repository navigation
opentelemetry-instrumentation-urllib3: keep pool headers when urlopen is called without headers - #5320
Open
ghdtjdwn wants to merge 2 commits into
Open
opentelemetry-instrumentation-urllib3: keep pool headers when urlopen is called without headers#5320ghdtjdwn wants to merge 2 commits into
ghdtjdwn wants to merge 2 commits into
Conversation
… gets none urllib3 falls back to the pool's default headers when urlopen() is called without headers. The instrumented urlopen replaced the missing headers with an empty dict before injecting, so the pool defaults were never sent. Start from a copy of the pool headers instead.
Pull request dashboard statusWaiting on reviewers · refreshed 2026-11-11 01:38 UTC Review the latest changes. Status above doesn't look right?
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
HTTPConnectionPool.urlopen()uses the pool's default headers when it is called withoutheaders. The instrumentedurlopenturns the missing headers into{}before injecting the propagation headers and passes that on, so urllib3 never falls back topool.headersand the defaults set on the pool are not sent.Start from a copy of
instance.headersin that case.pool.request()andPoolManagerpass the headers explicitly, so only directurlopen()calls were affected. For those calls the pool headers now also show up inRequestInfo.headersand in the capturedhttp.request.header.*attributes.Type of change
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
tox -e precommittox -e typecheck