Skip to content

opentelemetry-instrumentation-urllib3: keep pool headers when urlopen is called without headers #5320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ghdtjdwn wants to merge 2 commits into
base: main
Choose a base branch
from
Open

opentelemetry-instrumentation-urllib3: keep pool headers when urlopen is called without headers #5320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e85f3d6
opentelemetry-instrumentation-urllib3: keep pool headers when urlopen…
ghdtjdwn Nov 11, 2026
1039ada
Add changelog fragment
ghdtjdwn Nov 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/5320.fixed
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
`opentelemetry-instrumentation-urllib3`: keep the pool default headers when `urlopen` is called without headers
2 changes: 1 addition & 1 deletion ...entelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,7 +442,7 @@ def instrumented_urlopen(wrapped, instance, args, kwargs):
return wrapped(*args, **kwargs)

# avoid modifying original headers on inject
headers = headers.copy() if headers is not None else {}
headers = headers.copy() if headers is not None else instance.headers.copy()

sanitized_method = sanitize_method(method)
span_name = _get_span_name(sanitized_method)
Expand Down
13 changes: 13 additions & 0 deletions instrumentation/opentelemetry-instrumentation-urllib3/tests/test_urllib3_integration.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,3 +960,16 @@ def test_urlopen_mixed_args(self):
self.assertEqual(b"Hello!", response.data)
span = self.assert_span()
self.assertEqual(span.attributes["http.request.header.x_test"], ("Value",))

def test_urlopen_pool_headers(self):
URLLib3Instrumentor().uninstrument()
URLLib3Instrumentor().instrument(captured_request_headers=["X-Test"])
pool = urllib3.HTTPConnectionPool("mock", headers={"X-Test": "Value"})
response = pool.urlopen("GET", "/status/200")
self.assertEqual(b"Hello!", response.data)
span = self.assert_span()
headers = dict(Mocket.last_request().headers)
self.assertEqual(headers.get("x-test"), "Value")
self.assertIn("traceparent", headers)
self.assertEqual(span.attributes["http.request.header.x_test"], ("Value",))
self.assertEqual(pool.headers, {"X-Test": "Value"})
Loading