Skip to content

RT-1.21: BGP TCP MSS and PMTUD Changes Incorporated - #5872

Open
ampattan wants to merge 4 commits into
openconfig:mainfrom
nokia:AP-rt1dot21
Open

ampattan wants to merge 4 commits into
openconfig:mainfrom
nokia:AP-rt1dot21

Conversation

@ampattan

Copy link
Copy Markdown
Contributor

Updated metadata.textproto:

  • Removed the unwanted deviation.
  • Included omit_l2_mtu.

Updated bgp_tcp_mss_path_mtu_test.go:

  • Optimized the validation checks.
  • Added traffic-flow validation to verify TCP MSS behavior.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."

Updated metadata.textproto:

- Removed the unwanted deviation.
- Included omit_l2_mtu.

Updated bgp_tcp_mss_path_mtu_test.go:

- Optimized the validation checks.
- Added traffic-flow validation to verify TCP MSS behavior.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
@ampattan
ampattan requested a review from a team as a code owner August 10, 2026 14:59
@OpenConfigBot

OpenConfigBot commented Aug 10, 2026 •

Copy link
Copy Markdown

Pull Request Functional Test Report for #5872 / d85cbd3

Virtual Devices

Device Test Status Test Documentation Job Raw Log
Arista cEOS status
status
RT-1.22: pending authorization
RT-1.21: pending authorization
RT-1.22: BGP TCP MSS
RT-1.21: BGP TCP MSS and PMTUD
Cisco 8000E status
status
RT-1.22: pending authorization
RT-1.21: pending authorization
RT-1.22: BGP TCP MSS
RT-1.21: BGP TCP MSS and PMTUD
Cisco XRd status
status
RT-1.22: pending authorization
RT-1.21: pending authorization
RT-1.22: BGP TCP MSS
RT-1.21: BGP TCP MSS and PMTUD
Juniper ncPTX status
status
RT-1.22: pending authorization
RT-1.21: pending authorization
RT-1.22: BGP TCP MSS
RT-1.21: BGP TCP MSS and PMTUD
Nokia SR Linux status
status
RT-1.22: pending authorization
RT-1.21: pending authorization
RT-1.22: BGP TCP MSS
RT-1.21: BGP TCP MSS and PMTUD
Openconfig Lemming status
status
RT-1.22: pending authorization
RT-1.21: pending authorization
RT-1.22: BGP TCP MSS
RT-1.21: BGP TCP MSS and PMTUD

Hardware Devices

Device Test Status Test Documentation Raw Log
Arista status
status
RT-1.22: pending authorization
RT-1.21: pending authorization
RT-1.22: BGP TCP MSS
RT-1.21: BGP TCP MSS and PMTUD
Cisco status
status
RT-1.22: pending authorization
RT-1.21: pending authorization
RT-1.22: BGP TCP MSS
RT-1.21: BGP TCP MSS and PMTUD
Juniper status
status
RT-1.22: pending authorization
RT-1.21: pending authorization
RT-1.22: BGP TCP MSS
RT-1.21: BGP TCP MSS and PMTUD
Nokia status
status
RT-1.22: pending authorization
RT-1.21: pending authorization
RT-1.22: BGP TCP MSS
RT-1.21: BGP TCP MSS and PMTUD

Help

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the BGP TCP MSS and Path MTU test suite to improve robustness and accuracy. By refactoring validation checks into reusable helper functions and optimizing test configurations, the changes ensure more reliable verification of BGP TCP MSS values and proper traffic flow handling.

Highlights

  • Metadata Updates: Cleaned up metadata.textproto by removing unnecessary deviations and adding omit_l2_mtu.
  • Test Optimization: Refactored validation logic in bgp_tcp_mss_path_mtu_test.go to use helper functions for waiting on BGP TCP MSS states, improving test reliability.
  • Traffic Validation: Introduced continuous traffic flow validation to verify TCP MSS behavior under load.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the BGP TCP MSS Path MTU test to use helper functions for waiting on TCP MSS state changes and configures the DUT using 'cfgplugins'. It also adds a continuous traffic flow from OTG to DUT2. Feedback was provided to combine the traffic start and validation steps into a single subtest, using 'defer' to stop the traffic to prevent potential flakiness and ensure proper cleanup.

"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
@isnehashankar43

Copy link
Copy Markdown
Contributor

/fptest physical

@isnehashankar43

Copy link
Copy Markdown
Contributor

/fptest virtual

@AmrNJ

AmrNJ commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the BGP TCP MSS Path MTU test to use helper functions with gnmi.Watch for dynamic state verification and leverages cfgplugins for configuring BGP Max Segment Size. It also introduces a helper to start continuous OTG traffic. The review feedback highlights style guide violations, specifically the need to call otgutils.WaitForARP before starting OTG traffic to ensure neighbor resolution, importing the otgutils package, and registering a cleanup function using t.Cleanup to guarantee state reversion if subsequent tests fail.

Merge remote-tracking branch 'upstream/main' into AP-rt1dot21

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants