Repository navigation
Conversation
Updated metadata.textproto:
- Removed the unwanted deviation.
- Included omit_l2_mtu.
Updated bgp_tcp_mss_path_mtu_test.go:
- Optimized the validation checks.
- Added traffic-flow validation to verify TCP MSS behavior.
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
Pull Request Functional Test Report for #5872 / d85cbd3Virtual Devices
Hardware Devices
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the BGP TCP MSS and Path MTU test suite to improve robustness and accuracy. By refactoring validation checks into reusable helper functions and optimizing test configurations, the changes ensure more reliable verification of BGP TCP MSS values and proper traffic flow handling. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors the BGP TCP MSS Path MTU test to use helper functions for waiting on TCP MSS state changes and configures the DUT using 'cfgplugins'. It also adds a continuous traffic flow from OTG to DUT2. Feedback was provided to combine the traffic start and validation steps into a single subtest, using 'defer' to stop the traffic to prevent potential flakiness and ensure proper cleanup.
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."
|
/fptest physical |
|
/fptest virtual |
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request refactors the BGP TCP MSS Path MTU test to use helper functions with gnmi.Watch for dynamic state verification and leverages cfgplugins for configuring BGP Max Segment Size. It also introduces a helper to start continuous OTG traffic. The review feedback highlights style guide violations, specifically the need to call otgutils.WaitForARP before starting OTG traffic to ensure neighbor resolution, importing the otgutils package, and registering a cleanup function using t.Cleanup to guarantee state reversion if subsequent tests fail.
Merge remote-tracking branch 'upstream/main' into AP-rt1dot21
Updated metadata.textproto:
Updated bgp_tcp_mss_path_mtu_test.go:
"This code is a Contribution to the OpenConfig Feature Profiles project ("Work") made under the Google Software Grant and Corporate Contributor License Agreement ("CLA") and governed by the Apache License 2.0. No other rights or licenses in or to any of Nokia's intellectual property are granted for any other purpose. This code is provided on an "as is" basis without any warranties of any kind."