Repository navigation
RT-1.21: Update README for BGP TCP MSS and PMTUD - #6235
isnehashankar43 wants to merge 24 commits into
Conversation
* Define what transport/state/tcp-mss reports: the configured MSS, or optionally the MSS in use when no MSS is configured. Checks on the in-use value now apply only when a value is reported. * RT-1.21.2: set the DUT1 port-2 MTU so that DUT1 port-1 is the smallest MTU on the path, and document the multihop reachability setup. * Use RFC 5398 ASNs, add Canonical OC per subtest, pass/fail criteria and cleanup, and extend the path coverage.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the RT-1.21 test plan README to improve clarity and precision regarding BGP TCP MSS and PMTUD testing. The changes refine the test procedures, standardize ASNs, and introduce structured pass/fail criteria and Canonical OC configurations to ensure consistent test execution and validation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Pull Request Functional Test Report for #6235 / 1853effVirtual Devices
Hardware Devices
|
There was a problem hiding this comment.
Code Review
This pull request updates the README.md for the BGP TCP MSS and PMTUD test (RT-1.21). It expands the test plan with a detailed topology, DUT/OTG properties, step-by-step procedures for eBGP TCP MSS and multihop iBGP PMTUD testing, canonical OpenConfig configurations, pass/fail criteria, and updated path/RPC coverage. There are no review comments, and the changes are appropriate, so I have no feedback to provide.
* Summary: state/tcp-mss reports the applied configuration, in the same way as timers/state/hold-time. * RT-1.21.1: an MSS reported without configuration must be between the TCP default MSS (536 for IPv4, 1220 for IPv6) and the MTU minus 40/60. * RT-1.21.2: the PMTUD check now uses 536 to 1460.
* Remove the IPv6 link-local and in-use MSS leaf TODOs. * List only the tcp-mss and mtu-discovery paths in the coverage section. * Remove the platform restriction (N/A).
* eBGP IPv4/IPv6 on ATE port-1 and iBGP IPv4 with TCP MD5 on ATE port-2, both to the same DUT. Remove DUT2, IS-IS and the static route. * RT-1.21.1: state/tcp-mss must equal config/tcp-mss. * RT-1.21.2: the MSS in use must fit the 1500-byte MTU of ATE port-2.
24526e8 to
ddaedd3
Compare
|
/fptest virtual |
MD5 is not part of this feature and is covered by RT-1.1.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the README.md for the BGP TCP MSS and PMTUD test (RT-1.21) to provide a comprehensive test plan, including topology, detailed test procedures for neighbor and peer-group levels, canonical OpenConfig JSON configurations, and updated path coverage. The review feedback recommends adding a TODO to propose an OpenConfig leaf for reporting the TCP MSS in use on a session, and adding missing configuration and telemetry paths (such as interface MTU, session-state, and established-transitions) to the OpenConfig Path and RPC Coverage section.
* RT-1.21.1: MSS at the neighbor level. * RT-1.21.2: MSS at the peer-group level, inherited by the neighbors. * RT-1.21.3: PMTUD at the neighbor and peer-group levels, with no MSS configured.
* RT-1.21.1: MSS at the neighbor level, then at the peer-group level. * RT-1.21.2: PMTUD at the neighbor level, then at the peer-group level.
With the MSS (RT-1.21.1) or PMTUD (RT-1.21.2) set on the peer groups, override it on one neighbor of each peer group and verify that only that neighbor changes, while the other neighbors keep the peer-group value.
dplore
left a comment
There was a problem hiding this comment.
Thanks. I see the changes for TCP MSS which will test out MSS negotiation, but I don't see a step where the MTU of the physical port is smaller than the TCP MSS, forcing path MTU discovery to be performed.
pmprado
left a comment
There was a problem hiding this comment.
@isnehashankar43 - in order to make the PMTUD test actually test the feature, @dplore suggested a topology that I've tweaked:
[ ATE / Packet Generator ]
+------------------------+
| Port 1 Port 2 |
+----+--------------+----+
10.1.1.2/30 | | 10.3.3.2/30
MTU: 1500B | | MTU: 9216B
| |
+----+--------------+----+
MTU: 1500B | Port 1 Port 4 |
| [VRF-WEST] [VRF-EAST]|
| \ / |
MTU: 9216B | Port 2 Port 3 | MTU: 9216B
+------+-----------+-----+
| |
+-----------+
Direct Loop Cable
10.2.2.0/30
MTU: 9216B
Here, we'd enable a BGP session with PMTUD between a loopback of VRF-EAST and ATE Port1, which sits behind the strangled MTU.
We'd need to inject some big BGP updates in order to exceed the 1500 bytes of MTU and trigger PMTUD.
Sorry for the extra modification... Could you please make this ANOTHER change?
Moves the MSS test plan to a new test, RT-1.22, in feature/bgp/otg_tests/bgp_tcp_mss. RT-1.21 (bgp_tcp_mss_path_mtu) is left unchanged.
Goes back to one RT-1.21 test for both MSS and PMTUD, and removes the RT-1.22 folder. The test uses the TESTBED_DUT_1_LOOP_2_ATE testbed: a loop cable joins the DEFAULT network instance, where BGP runs, to a TRANSIT network instance, which is a router between the DUT BGP speaker and ATE port-1. RT-1.21.2 lowers the MTU of that router's link to ATE port-1 and verifies that large BGP UPDATEs still arrive.
@pmprado @dplore The README now tests PMTUD through a loop on one DUT, as you proposed, on a new testbed TESTBED_DUT_1_LOOP_2_ATE (dut:port1-ate:port1, dut:port2-dut:port3, dut:port4-ate:port2). The loop link can be a cable or an OCS cross-connect. Three things differ from the sketch:
The PMTUD step passes if all prefixes reach ATE port-1, the sessions stay ESTABLISHED, and a capture on ATE port-1 shows DUT packets of more than 1280 bytes and no IPv4 fragments. The testbed definition (topology file and enum) is in #6274. |
|
Is this expected to fail on Cisco? I see from the test results it's failing there? Also, I think it is better to include the topology change in this PR too, otherwise fptest isn't going to be using that topo? |
Adds RT-1.22 in a new folder, feature/bgp/otg_tests/bgp_tcp_mss: the TCP MSS on a single DUT (TESTBED_DUT_ATE_2LINKS), at the neighbor and peer-group levels, with the neighbor-level override. RT-1.21 (bgp_tcp_mss_path_mtu) is restored to its version on main and still covers PMTUD.
This updates the RT-1.21 test plan (README) for BGP TCP MSS and PMTUD.
transport/state/tcp-mssreports: the configured MSS (applied configuration); when no MSS is configured, the MSS in use may be reported instead.