Skip to content

Add the TESTBED_DUT_1_LOOP_2_ATE testbed - #6274

Open
isnehashankar43 wants to merge 1 commit into
openconfig:mainfrom
isnehashankar43:testbed-dut-1-loop-2-ate
Open

isnehashankar43 wants to merge 1 commit into
openconfig:mainfrom
isnehashankar43:testbed-dut-1-loop-2-ate

Conversation

@isnehashankar43

@isnehashankar43 isnehashankar43 commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Adds the TESTBED_DUT_1_LOOP_2_ATE testbed: one DUT with one loop link (dut:port2 to dut:port3) and two ATE links (dut:port1 to ate:port1, dut:port4 to ate:port2). The loop link can be a cable or an optical circuit switch cross-connect.

The loop lets one DUT act as a router between two of its own network instances. RT-1.21 (#6235) uses it to test BGP path MTU discovery: BGP runs in DEFAULT, and a second network instance on port1 and port2 is the router between the DUT BGP speaker and ATE port1.

  • topologies/dut_1_loop_2_ate.testbed: new topology file.
  • proto/metadata.proto: TESTBED_DUT_1_LOOP_2_ATE = 21, and the regenerated metadata.pb.go.
  • internal/fptest/runtests.go: maps the new testbed to its topology file.

A DUT with one physical loop (dut:port2 to dut:port3) and two ATE links (dut:port1 to ate:port1 and dut:port4 to ate:port2). The loop lets one DUT act as a router between two of its own network instances. RT-1.21 uses it to test BGP path MTU discovery.
@isnehashankar43
isnehashankar43 requested a review from a team as a code owner November 11, 2026 12:25
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new testbed topology, 'DUT_1_LOOP_2_ATE', designed to support BGP path MTU discovery testing. The changes involve defining the new testbed in the metadata protocol buffers, creating the topology file, and updating the internal test runner to recognize and utilize this new configuration.

Highlights

  • New Testbed Configuration: Added a new testbed configuration 'TESTBED_DUT_1_LOOP_2_ATE' which defines a DUT with one physical loop and two ATE links.
  • Protocol Buffer Update: Updated 'metadata.proto' to include the new testbed enum value and regenerated the corresponding Go protobuf files.
  • Testbed Mapping: Updated 'runtests.go' to map the new testbed enum to its respective '.testbed' file.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@OpenConfigBot

Copy link
Copy Markdown

Pull Request Functional Test Report for #6274 / 19a2e04

No tests identified for validation.

Help

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new testbed topology, dut_1_loop_2_ate.testbed, which configures a DUT with one physical loop and an ATE with two links to the DUT. The metadata protobuf definitions and regenerated Go protobuf files are updated to support this new topology. I have no feedback to provide.

@pmprado

pmprado commented Nov 11, 2026

Copy link
Copy Markdown

/gemini how to test this topology ?

@gemini-code-assist

Copy link
Copy Markdown
Contributor

To test this new topology, you should specify the TESTBED_DUT_1_LOOP_2_ATE enum value in the metadata.textproto file of your test.

Since this testbed is designed for BGP path MTU discovery, you can reference existing tests that use similar loopback topologies (like those in feature/bgp/otg_tests/) as a template for your test implementation. Once the metadata is updated, the test runner will automatically map the enum to the topologies/dut_1_loop_2_ate.testbed file you've added, and the ondatra framework will handle the physical topology setup accordingly.

@navaneethyv

Copy link
Copy Markdown
Contributor

@AmrNJ can this be taken care of any one of the existing ones already ?

# proto-file: github.com/openconfig/ondatra/blob/main/proto/testbed.proto
# proto-message: ondatra.Testbed

# This testbed provides a DUT with 1 physical loop (dut:port2 <-> dut:port3)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@navaneethyv just to note that the loop here is automatically done by the OCS

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants