Repository navigation
Add the TESTBED_DUT_1_LOOP_2_ATE testbed - #6274
isnehashankar43 wants to merge 1 commit into
Conversation
A DUT with one physical loop (dut:port2 to dut:port3) and two ATE links (dut:port1 to ate:port1 and dut:port4 to ate:port2). The loop lets one DUT act as a router between two of its own network instances. RT-1.21 uses it to test BGP path MTU discovery.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new testbed topology, 'DUT_1_LOOP_2_ATE', designed to support BGP path MTU discovery testing. The changes involve defining the new testbed in the metadata protocol buffers, creating the topology file, and updating the internal test runner to recognize and utilize this new configuration. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a new testbed topology, dut_1_loop_2_ate.testbed, which configures a DUT with one physical loop and an ATE with two links to the DUT. The metadata protobuf definitions and regenerated Go protobuf files are updated to support this new topology. I have no feedback to provide.
|
/gemini how to test this topology ? |
|
To test this new topology, you should specify the Since this testbed is designed for BGP path MTU discovery, you can reference existing tests that use similar loopback topologies (like those in |
|
@AmrNJ can this be taken care of any one of the existing ones already ? |
| # proto-file: github.com/openconfig/ondatra/blob/main/proto/testbed.proto | ||
| # proto-message: ondatra.Testbed | ||
|
|
||
| # This testbed provides a DUT with 1 physical loop (dut:port2 <-> dut:port3) |
There was a problem hiding this comment.
@navaneethyv just to note that the loop here is automatically done by the OCS
Adds the TESTBED_DUT_1_LOOP_2_ATE testbed: one DUT with one loop link (dut:port2 to dut:port3) and two ATE links (dut:port1 to ate:port1, dut:port4 to ate:port2). The loop link can be a cable or an optical circuit switch cross-connect.
The loop lets one DUT act as a router between two of its own network instances. RT-1.21 (#6235) uses it to test BGP path MTU discovery: BGP runs in DEFAULT, and a second network instance on port1 and port2 is the router between the DUT BGP speaker and ATE port1.