[giswqs]

Cause: #1207 fixed Buffer's outlines, so buffer a long line, buffer polygons and buffer polygons inward now agree with the reference. tools_agree_with_the_reference fails on any case that agrees while still carrying a known mark. #1207 was tested before #1161 added those marks to main, so the conflict only appeared once both had landed, and every PR's test / Test (ubuntu-latest) fails on it.

Fix: remove the three marks from generate.py and cases.json. Their strict tolerance now applies, so a regression there fails the test.

Evidence: the test failed on a clean origin/main (78b1799) with those three messages, and passes with this change.

Left as it is: buffer points, buffer points far and buffer lines still differ from the reference by about 6e-3 and 1e-3 of their area, inside the 10 % bound, and keep their marks. Those marks name #1159, which is closed, so they need a new issue or a fix of their own.

Summary by CodeRabbit

• Tests
  • Updated reference expectations for long-line and polygon buffer cases to use the standard tolerance. Point and station buffer cases retain their existing tolerance overrides.
  • These changes affect test validation only; no end-user functionality has changed.

[coderabbitai]

No actionable comments were generated in the recent review.

Recent review info

Run configuration

• Source mode: Auto
• Repository: Unavailable
• Branch: Unavailable
• File: No configuration file from this repository applied
• Commit: Unavailable
• Layers: Organization UI
• Review profile: ASSERTIVE
• Plan: Advanced
• Run ID: e193617e-b801-4100-9e7d-ae91f1b9bc09

Commits

Reviewing files that changed from the base of the PR and between 78b1799 and 6fbc655.

Files selected for processing: 2

• crates/analysis/tests/reference/cases.json
• crates/analysis/tests/reference/generate.py

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review.

Walkthrough

Three buffer reference cases no longer include issue #1159 metadata or its 0.1 tolerance override. Their expected-result tolerance remains 0.001.

Changes: Buffer reference cases

Layer / File(s)	Summary
Remove buffer case overrides crates/analysis/tests/reference/cases.json, crates/analysis/tests/reference/generate.py	The long-line, outward polygon, and inward polygon cases no longer use the known-issue metadata or tolerance override. Their expected tolerance remains 0.001.

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Possibly related issues

• [Bug]: Buffer outlines sit up to 10 % of the distance off: long sides come back from the plane straight, and arcs have 32 edges #1159 — Identifies inaccurate buffer outlines and the reference cases updated here.

Possibly related PRs

• opengeos/RustGIS#1161 — Added the buffer reference cases and their known-issue metadata.
• opengeos/RustGIS#1207 — Changed buffer outline generation for the cases whose known-issue marks are removed here.

Suggested reviewers: mavrick-f

Merge Risk: Minimal · up to 6fbc6

The three buffer cases return to strict reference comparisons. No actionable merge-blocking risk is identified; merge after normal checks pass.

Pre-merge checks: 4 · 1

Failed checks: 1 warning

Check name	Status	Explanation	Resolution
Docstring Coverage		Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…	Write docstrings for the functions missing them to satisfy the coverage threshold.

Passed checks: 4 passed

Check name	Status	Explanation
Title check		The title "test(analysis): drop the known marks #1207 made stale" names the main change: removing outdated known marks from buffer test cases. It is specific and matches the changeset, which removes…
Description check		The description follows the repository template in substance. It covers the cause, the fix, and the evidence. It explains why the three marks were removed and why the other three marks remain. The tem…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title "test(analysis): drop the known marks #1207 made stale" names the main change: removing outdated known marks from buffer test cases. It is specific and matches the changeset, which removes those marks from generate.py and cases.json. It names the test scope and the cause, so a teammate scanning history understands the primary change.

Full details: Description check

Explanation

The description follows the repository template in substance. It covers the cause, the fix, and the evidence. It explains why the three marks were removed and why the other three marks remain. The template's Summary is covered by the Cause and Fix sections. The Testing section is covered by the Evidence section, which describes a failing run on clean origin/main and a passing run with the change, but it does not name a command such as cargo xtask ci. The UI evidence section is omitted, which is acceptable because the change has no visible UI effect. The Related issue section is not explicit: it refers to #1207 and #1161 and to closed issue #1159, but it lacks a "Closes" or "Part of" line for the PR itself.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches

Generate docstrings

• Commit to this branch
• Create a new PR

Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit checks the lines with care
Three buffer marks are no longer there
The tolerance stays in place
The cases keep their expected pace
Hop, the reference tests compare!}

[github-actions]

Code review

Bugs: None found. The PR removes three known marks from generate.py and the matching blocks from cases.json. Both files were checked:

• cases.json is still valid JSON, and the three cases now carry only the strict tolerance: 0.001.
• generate.py writes cases.json itself. The hand edit matches its output format, since case() omits known when it is falsy.
• tools_agree_with_the_reference in crates/analysis/tests/reference.rs (lines 314-349) fails any case that agrees while still marked, so removing the marks makes these three cases strict as the PR says.

Security: None. The change is test fixtures and a generator tweak.

Performance: None.

Quality:

• The three remaining marks (buffer points, buffer points far, buffer lines) name [Bug]: Buffer outlines sit up to 10 % of the distance off: long sides come back from the plane straight, and arcs have 32 edges #1159, which the PR body says is closed. The module doc in reference.rs (lines 5-8) says a mark covers an open issue. I left an inline comment on generate.py:518, a changed line, suggesting a new issue and an updated mark. Confidence: medium-high. I could not check [Bug]: Buffer outlines sit up to 10 % of the distance off: long sides come back from the plane straight, and arcs have 32 edges #1159's state because I have no network access.

AGENTS.md: No violations. The test change needs no crash regression test, and no copyleft code or assets are involved.

Not verified: I could not run cargo test here, so the claim that the three cases now agree within 0.001 rests on the PR's own evidence. CI on the PR will confirm it.

Change size

Compared: the whole PR against main (merge base 78b1799 to PR head 6fbc655).

Measure	Value
Files changed	2 (added 0, modified 2, removed 0, renamed 0)
Size before	41.8 KB
Size after	41.5 KB
Total size change	-366 B

Path	Before	After	Change
crates/analysis/tests/reference/cases.json	14.7 KB	14.4 KB	-345 B
crates/analysis/tests/reference/generate.py	27.1 KB	27.0 KB	-21 B

[github-actions]

📖 Docs preview

Item	Value
Preview	https://preview.rustgis.app/pr-1220/
Web app	https://preview.rustgis.app/pr-1220/app/
Commit	6fbc655

GitHub Pages takes a minute or two to publish a new commit.