Skip to content

test(engine): compare export answers with Windows paths escaped as JSON #1439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
giswqs merged 1 commit into from
Nov 4, 2026
Merged

test(engine): compare export answers with Windows paths escaped as JSON #1439

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion crates/engine/src/tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27255,7 +27255,11 @@ fn exports_run_on_another_thread() {
assert!(s.notices_since(mark).is_empty(), "{command}: nothing is said before it lands");
let answer_there = export_land(&mut s, wrote);
assert_eq!(said(&s, mark, &there), said_here, "{command} {file}");
let unpathed = |v: &Value, path: &str| v.to_string().replace(path, "PATH");
// The path as it appears in JSON: on Windows its backslashes are escaped there.
let unpathed = |v: &Value, path: &str| {
let escaped = json!(path).to_string();
v.to_string().replace(escaped.trim_matches('"'), "PATH")
Comment thread
giswqs marked this conversation as resolved.
Resolved
};
assert_eq!(unpathed(&answer_there, &there), unpathed(&answer_here, &here), "{command} {file}");
// A GeoPackage holds the time it was written: its features are compared instead.
if file.ends_with(".gpkg") {
Expand Down
Loading