Skip to content

Default package exports to OFF for embedded builds - #64

Closed
gwendalsimon wants to merge 1 commit into
mainfrom
fix/subproject-package-exports
Closed

gwendalsimon wants to merge 1 commit into
mainfrom
fix/subproject-package-exports

Conversation

@gwendalsimon

@gwendalsimon gwendalsimon commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

moq5 now generates its CMake package exports by default only when it is the top-level project. Since bac37c6, an embedding project that builds picoquic itself fails at generate time. moqxr reports "export called with target moq-adapter-picoquic which requires target picoquic-core that is not in any export set". An embedding project that wants the package sets MOQ_BUILD_PACKAGE_EXPORTS=ON. An explicit ON still refuses unexported providers.

A new embedding test row fails without the change. With the change, the default preset passes 410 of 410 tests. moqxr's libmoq job configures and builds again.


This change is Reviewable

* Default MOQ_BUILD_PACKAGE_EXPORTS to ON only when libmoq is the
  top-level project. Since bac37c6 every component calls export(EXPORT),
  so an embedding project that supplies its own picoquic (moqxr) fails
  at generate time: "requires target picoquic-core that is not in any
  export set".
* Keep the explicit ON refusal for unexported source providers.
* Opt the package-qualification producer fixture in explicitly.
* Add an embedding row that leaves the option unset with an unexported
  provider and expects a clean configure with no package files.
* Update README and docs/cmake-component-exports.md.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rwl4

rwl4 commented Nov 17, 2026

Copy link
Copy Markdown
Collaborator

This is in. Thanks, Gwendal.

@rwl4 rwl4 closed this Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants