Repository navigation
Default package exports to OFF for embedded builds - #64
Closed
gwendalsimon wants to merge 1 commit into
Closed
gwendalsimon wants to merge 1 commit into
gwendalsimon wants to merge 1 commit into
Conversation
* Default MOQ_BUILD_PACKAGE_EXPORTS to ON only when libmoq is the top-level project. Since bac37c6 every component calls export(EXPORT), so an embedding project that supplies its own picoquic (moqxr) fails at generate time: "requires target picoquic-core that is not in any export set". * Keep the explicit ON refusal for unexported source providers. * Opt the package-qualification producer fixture in explicitly. * Add an embedding row that leaves the option unset with an unexported provider and expects a clean configure with no package files. * Update README and docs/cmake-component-exports.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rwl4
added a commit
that referenced
this pull request
Nov 15, 2026
Collaborator
|
This is in. Thanks, Gwendal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
moq5 now generates its CMake package exports by default only when it is the top-level project. Since bac37c6, an embedding project that builds picoquic itself fails at generate time. moqxr reports "export called with target moq-adapter-picoquic which requires target picoquic-core that is not in any export set". An embedding project that wants the package sets
MOQ_BUILD_PACKAGE_EXPORTS=ON. An explicit ON still refuses unexported providers.A new embedding test row fails without the change. With the change, the default preset passes 410 of 410 tests. moqxr's libmoq job configures and builds again.
This change is