Repository navigation
Conversation
Backport upstream picoquic PR2369 (36f49b73) as patch 0012. Without it, picoquic_compute_ack_gap_and_delay can request a max ack delay below the peer's min_ack_delay when the peer advertises more than 10 ms (quicly uses 25 ms), and quicly closes with PROTOCOL_VIOLATION on frame 0xaf. The patch includes upstream's ackfrq_min_delay test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Superseded by #69, which moved picoquic to 36f49b73. That commit includes upstream PR2369, so the 0012 backport is no longer needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
patches/picoquic/0012-ack-frequency-min-ack-delay-floor.patch, a backport of upstream picoquic #2369 (merged as36f49b73). It is applied on top of the current70b5fd5pin.Problem
picoquic_compute_ack_gap_and_delaycan ask for an ACK_FREQUENCY max ack delay below the peer'smin_ack_delay. Three conditions trigger it:min_ack_delayabove 10 ms (quicly advertises 25 ms),quicly then closes the connection with PROTOCOL_VIOLATION on frame type
0xaf. The fix raises the delay back toremote_min_ack_delayafter the 10 ms cap.Why a patch and not a pin bump
70b5fd5is 162 commits behind36f49b7. On that commit, patches 0003, 0004 and 0006–0011 no longer apply, so changing the pin alone would break the series. A full pin bump with those patches rebased will come as a separate PR. When it lands, patch 0012 can be removed; the README's removal table records this.moqxr's
OPENMOQ_USE_LIBMOQ_PUBLISHER=ONbuild reads moq5 main's pin and series, so it picks this change up without any moqxr edit.Testing
scripts/setup_picoquic_deps.shapplies the full series, 0001–0012, to a clean70b5fd5checkout.picoquic_ct:ackfrq_basic,ackfrq_short,ackfrq_min_delayandack_of_ackpass. With theframes.chunk reverted,ackfrq_min_delayfails (requested 10000 µs < 25000 µs).ctest: 513 of 523 tests pass, including the provider-patch series self-tests. The 10 failures are local environment issues and unrelated to this change:cmake_manual_exports_*tests and the multi-config step ofpicoquic_setup_recipeneed Ninja, which is not installed on this machine.consumer_warning_diagnosticsfails on a CMake argument error.🤖 Generated with Claude Code
This change is