Skip to content

Carry picoquic ACK_FREQUENCY min_ack_delay floor - #68

Closed
zshenker wants to merge 1 commit into
openmoq:mainfrom
zshenker:picoquic-ackfrq-min-delay
Closed

zshenker wants to merge 1 commit into
openmoq:mainfrom
zshenker:picoquic-ackfrq-min-delay

Conversation

@zshenker

@zshenker zshenker commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Adds patches/picoquic/0012-ack-frequency-min-ack-delay-floor.patch, a backport of upstream picoquic #2369 (merged as 36f49b73). It is applied on top of the current 70b5fd5 pin.

Problem

picoquic_compute_ack_gap_and_delay can ask for an ACK_FREQUENCY max ack delay below the peer's min_ack_delay. Three conditions trigger it:

  • the peer advertises a min_ack_delay above 10 ms (quicly advertises 25 ms),
  • there is some queueing,
  • the return data rate is low.

quicly then closes the connection with PROTOCOL_VIOLATION on frame type 0xaf. The fix raises the delay back to remote_min_ack_delay after the 10 ms cap.

Why a patch and not a pin bump

70b5fd5 is 162 commits behind 36f49b7. On that commit, patches 0003, 0004 and 0006–0011 no longer apply, so changing the pin alone would break the series. A full pin bump with those patches rebased will come as a separate PR. When it lands, patch 0012 can be removed; the README's removal table records this.

moqxr's OPENMOQ_USE_LIBMOQ_PUBLISHER=ON build reads moq5 main's pin and series, so it picks this change up without any moqxr edit.

Testing

  • scripts/setup_picoquic_deps.sh applies the full series, 0001–0012, to a clean 70b5fd5 checkout.
  • picoquic picoquic_ct: ackfrq_basic, ackfrq_short, ackfrq_min_delay and ack_of_ack pass. With the frames.c hunk reverted, ackfrq_min_delay fails (requested 10000 µs < 25000 µs).
  • moq5 built against the patched tree, ctest: 513 of 523 tests pass, including the provider-patch series self-tests. The 10 failures are local environment issues and unrelated to this change:
    • 8 cmake_manual_exports_* tests and the multi-config step of picoquic_setup_recipe need Ninja, which is not installed on this machine.
    • consumer_warning_diagnostics fails on a CMake argument error.

🤖 Generated with Claude Code


This change is Reviewable

Backport upstream picoquic PR2369 (36f49b73) as patch 0012. Without it,
picoquic_compute_ack_gap_and_delay can request a max ack delay below the
peer's min_ack_delay when the peer advertises more than 10 ms (quicly
uses 25 ms), and quicly closes with PROTOCOL_VIOLATION on frame 0xaf.
The patch includes upstream's ackfrq_min_delay test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@zshenker

Copy link
Copy Markdown
Contributor Author

Superseded by #69, which moved picoquic to 36f49b73. That commit includes upstream PR2369, so the 0012 backport is no longer needed.

@zshenker zshenker closed this Nov 17, 2026
@zshenker
zshenker deleted the picoquic-ackfrq-min-delay branch November 17, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant