Repository navigation
Move picoquic to 36f49b73 - #69
Merged
Merged
Conversation
Pin picoquic to 36f49b73 (release v2026.11.12.36f49b7), which includes
upstream PR2369 (ACK_FREQUENCY max ack delay floor at the peer's
min_ack_delay), and rebase the picoquic series onto it.
Rebase changes:
- 0003 uses upstream's cached first stream segment, and unlinks a queued
close check in picoquic_stream_node_delete, where upstream now has the
connection. Its direct-receive tests, and 0010's, queue data behind a
missing first byte, since upstream no longer queues in-order data for a
connection without a callback.
- 0004 re-registers the reset secret in upstream's new
picoquic_promote_tuple_to_default, which also covers NAT rebinding.
- 0006 appends picohttp_callback_stream_send_committed after upstream's
new picohttp_callback_app_wakeup.
- 0011's test follows upstream's single cipher-suite table.
LibMoQ follows upstream's rename of initial_max_stream_id_{uni,bi}dir to
initial_max_streams_{uni,bidi}, and pq_zero_rtt_refused's raw client gets
a callback that accepts every event.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the picoquic pin from
70b5fd5to36f49b73, releasev2026.11.12.36f49b7. This is upstream master at the time of writing and is 162 commits ahead. It includes #2369, the ACK_FREQUENCYmin_ack_delayfloor, so this supersedes #68. If #68 merges first, this PR drops its 0012 and series entry.Rebasing the series
0001, 0002, 0005, 0007, 0008, 0009 and 0010 applied unchanged in substance. The others needed real changes:
first_stream_data(83cd9728). The direct-receive guard and the undelivered-node lookup now start from the cached node.stream->cnx(9fb927c8) and moved output-stream unlinking intopicoquic_stream_node_delete. The queued close-check dequeue moved there as well.stream_direct_receive_handoverand thedirect_receive_close_checkscenarios that 0003 and 0010 share, now queue data and FIN behind a missing first byte. That byte is injected directly so no retransmission follows, and the app needs the stream only from that byte on. Every assertion is unchanged.picoquic_promote_tuple_to_defaultand added a NAT-rebinding caller. The reset-secret re-registration now happens inside that helper, so both paths keep the "refreshed whenever the default path's first tuple changes" contract.picohttp_callback_stream_send_committedcomes after upstream's newpicohttp_callback_app_wakeup.ptls_cipher_suite_t*table, after the fusion removal. The lock itself is unchanged, and upstream's new algorithm-selection code only reads the tables.The preambles and
patches/picoquic/README.mdare updated. The README adds a Superseded entry for #2369 and one for the NULL-callback change.LibMoQ changes
initial_max_stream_id_{uni,bi}dirtoinitial_max_streams_{uni,bidi}(157543f1). The pico_wt and picoquic adapters, their tests and their header comments are updated. No moq5 API changes.pq_zero_rtt_refused: the raw client used a NULL default callback, which is now refused during the handshake. It now passes a callback that accepts every event.publish-interop-client.yml,adapters/picoquic/README.mdand aFindPicoquic.cmakecomment.Behavior note:
pq_release_cnx,moq_pq_conn_destroyand the pico_wt teardown paths detach a live connection withpicoquic_set_callback(cnx, NULL, NULL). With this picoquic, any later event on that connection gets the refusing callback. Stream data, for example, now closes the connection with INTERNAL_ERROR instead of staying queued. The moq5 tests pass, but the change affects a caller-owned client connection that outlives its adapter.Testing
scripts/setup_picoquic_deps.shfetches36f49b73and applies 0001–0011. The resulting tree is identical, as a git tree hash, to the rebased series it was generated from.picoquic_ct: 766 of 766 pass.ctest: 513 of 523 pass, the same result asmainon this machine. The provider-patch series self-tests pass. The 10 failures are local environment issues and unrelated to this change:cmake_manual_exports_*tests and the multi-config step ofpicoquic_setup_recipeneed Ninja, which is not installed here.consumer_warning_diagnosticshits an unrelated CMake argument error.🤖 Generated with Claude Code
This change is