[oadp-1.4] OADP 8452: Add readiness probes and service accounts to CLI download server

[NicholasYancey]

Why the changes were made

The Telco certification access-control-pod-service-account and access-control-pod-role-bindings checks fail because the oadp-cli-server container (deployed to serve CLI binary downloads via ConsoleCLIDownload) uses the default service account.

This PR creates a dedicated ServiceAccount (openshift-adp-cli-server), adds ReadinessProbe and LivenessProbe to the container, and backfills both onto any already-running Deployments on operator upgrade.
Backport of #2306 to oadp-1.4. The VMDP server does not exist in this branch so only CLI changes are included.

Jira link: https://redhat.atlassian.net/browse/OADP-8452

How to test the changes made

Deploy the operator from this branch:

make deploy

Confirm the download-server Deployment now has probes defined:

oc -n openshift-adp get deploy openshift-adp-oadp-cli-server \
  -o jsonpath='{.spec.template.spec.containers[0].readinessProbe}{"\n"}'

Should return a populated httpGet probe object, not empty.

Confirm the pod uses the dedicated service account:

oc -n openshift-adp get pod -l app=oadp-cli \
  -o jsonpath='{.items[0].spec.serviceAccountName}{"\n"}'

Should return openshift-adp-cli-server.

Confirm the pod reports Ready:

oc get pods -n openshift-adp -l app=oadp-cli

READY column should show 1/1.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 73ab9163-febf-4051-9a07-91bf21b299be

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 75 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.15%. Comparing base (e334d7d) to head (b4e0b28).

⚠️ Current head b4e0b28 differs from pull request most recent head bff9e1a

Please upload reports for the commit bff9e1a to get more accurate results.

Files with missing lines	Patch %	Lines
controllers/cli_download_controller.go	0.00%	75 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##           oadp-1.4    #2312      +/-   ##
============================================
- Coverage     32.62%   32.15%   -0.48%     
============================================
  Files            30       30              
  Lines          4861     4933      +72     
============================================
  Hits           1586     1586              
- Misses         3100     3172      +72     
  Partials        175      175              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[NicholasYancey]

/retest

[openshift-ci]

@NicholasYancey: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[weshayutin]

/LGTM

[Joeavaikath]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: NicholasYancey, sseago, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment