Skip to content

[DREAM-75] Primerise Branding tab of Admin/Design page - #26206

Open
HDinger wants to merge 5 commits into
devfrom
feature/dream-75-primerise-branding-tab-of-admin-design-page
Open

[DREAM-75] Primerise Branding tab of Admin/Design page#26206
HDinger wants to merge 5 commits into
devfrom
feature/dream-75-primerise-branding-tab-of-admin-design-page

Conversation

@HDinger

@HDinger HDinger commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

Ticket

Feature ticket: https://community.openproject.org/wp/DREAM-75
Including its Implementation ticket https://community.openproject.org/wp/DREAM-928

What are you trying to accomplish?

FileField component

  • Matches https://community.openproject.org/wp/DREAM-928, done in the first commit
  • Adds a new Primer form input: a dashed-border drop zone with drag & drop, live image preview, and a replace/delete action menu (hidden when disabled).
  • Reuses Primer's FormControl (accessible, visually-hidden <label>, caption, validation message)

Primerize Admin/Design Branding tab

  • Matches https://community.openproject.org/wp/DREAM-75, done in the second commit
  • _image.html.erb now uses a primer form and the new file_field
  • The three desktop/mobile logo variants (light / light-high-contrast / dark) are laid out side by side
  • Each logo variant previews against the background it will actually appear behind (configured header color / black / grey for dark and high-contrast modes).

Screenshots

Bildschirmfoto 2026-10-21 um 15 21 28

AI involvement

Collaborative – AI generated a substantial part of the code; I reviewed and understand every line.

@HDinger HDinger added this to the 18.0.x milestone Oct 21, 2026
@github-actions github-actions Bot added the ai: Collaborative 💻 AI generated a substantial part of the code; A human reviewed and understands every line. label Oct 21, 2026
@opf opf deleted a comment from github-actions Bot Oct 21, 2026
@opf opf deleted a comment from github-actions Bot Oct 21, 2026
@opf opf deleted a comment from github-actions Bot Oct 21, 2026
@opf opf deleted a comment from github-actions Bot Oct 21, 2026
@HDinger
HDinger force-pushed the feature/dream-75-primerise-branding-tab-of-admin-design-page branch 2 times, most recently from 8a1bef4 to f172ec6 Compare October 22, 2026 07:26
@HDinger
HDinger force-pushed the feature/dream-75-primerise-branding-tab-of-admin-design-page branch from f172ec6 to 59ea370 Compare October 22, 2026 11:46
@HDinger
HDinger added this pull request to stack #26235 October 22, 2026 14:03
bsatarnejad
bsatarnejad requested changes Oct 23, 2026
View reviewed changes
Comment thread lib/primer/open_project/forms/file_field.html.erb
Comment thread frontend/src/stimulus/controllers/file-field.controller.ts
Comment thread app/views/custom_styles/_branding.html.erb
Comment thread app/views/custom_styles/_branding.html.erb
@HDinger

HDinger commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Hi @bsatarnejad
I included your feedback. Couldy you please have another look?

@HDinger
HDinger requested a review from bsatarnejad October 23, 2026 13:03
bsatarnejad
bsatarnejad requested changes Oct 23, 2026
View reviewed changes
Comment thread frontend/src/stimulus/controllers/file-field.controller.ts
Comment thread frontend/src/global_styles/content/_custom_logo.sass Outdated
@bsatarnejad bsatarnejad mentioned this pull request Oct 23, 2026
Open
@HDinger
HDinger requested a review from bsatarnejad October 26, 2026 07:44

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsatarnejad bsatarnejad Awaiting requested review from bsatarnejad

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

ai: Collaborative 💻 AI generated a substantial part of the code; A human reviewed and understands every line. feature needs review styling

Milestone

18.0.x

Development

Successfully merging this pull request may close these issues.

2 participants

@HDinger @bsatarnejad