Repository navigation
Conversation
## Motivation `formatISO`, `formatToNow` and `formatToNowStrict` only reject an empty input, then hand the result of `parseJSON` straight to date-fns: ```ts const p = parseJSON(s); return format(p, layout || FORMAT_YMD); // RangeError: Invalid time value ``` A value that is not a date makes every one of them throw. `formatISO` is what `transDataForOverview` uses for the chart's x-axis, so one malformed time string in a series takes the metric page down instead of leaving a gap. ## Change Check `isValid(p)` after parsing and return `''` when it fails, matching the existing empty-input behaviour. ## Verification ``` # tests only ● returns an empty string for a value that is not a date RangeError: Invalid time value Tests: 1 failed, 3 passed, 4 total # with the fix Tests: 4 passed, 4 total ``` Signed-off-by: Yxq <yu2651701064@tju.edu.cn>
|
@tju-yxq is attempting to deploy a commit to the codersett's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
formatISO,formatToNowandformatToNowStrictonly reject an empty input, then hand the result ofparseJSONstraight to date-fns:A value that is not a date makes every one of them throw.
formatISOis whattransDataForOverviewuses for the chart's x-axis, so one malformed time string in a series takesthe metric page down instead of leaving a gap.
Change
Check
isValid(p)after parsing and return''when it fails, matching the existing empty-inputbehaviour.
Verification