Skip to content

fix: return an empty string for a time value that cannot be parsed #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tju-yxq wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: return an empty string for a time value that cannot be parsed #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions apps/web/src/common/utils/time.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,10 @@ describe('time', () => {
it('formatToNowStrict', function () {
expect(formatToNowStrict('2022-09-28T02:11:54Z')).toBe('2 months');
});

it('returns an empty string for a value that is not a date', () => {
expect(formatISO('not-a-date')).toEqual('');
expect(formatToNow('not-a-date')).toEqual('');
expect(formatToNowStrict('not-a-date')).toEqual('');
});
});
6 changes: 6 additions & 0 deletions apps/web/src/common/utils/time.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import {
isValid,
formatDistanceToNow,
formatDistanceToNowStrict,
format,
Expand All @@ -14,18 +15,23 @@ const languages = { en: enGB, zh: zhCN };
export const formatISO = (s: string, layout?: string) => {
if (!s) return '';
const p = parseJSON(s);
// date-fns format() throws RangeError on an invalid date; a malformed value in
// the series must not take the whole page down.
if (!isValid(p)) return '';
return format(p, layout || FORMAT_YMD);
};

export const formatToNow = (s: string) => {
if (!s) return '';
const p = parseJSON(s);
if (!isValid(p)) return '';
return formatDistanceToNow(p, { locale: languages[local] });
};

export const formatToNowStrict = (s: string) => {
if (!s) return '';
const p = parseJSON(s);
if (!isValid(p)) return '';
return formatDistanceToNowStrict(p, { locale: languages[local] });
};

Expand Down