Repository navigation
Conversation
convertResult maps result.summaryMedian from result.summaryMean (a copy-paste of the line above): the blue median dashed line on the Updated-Since card renders the mean values, so median and average coincide whenever mean != median - and the median is wrong everywhere they differ. ChartDataProvider builds the two series from distinct API fields (transSummaryToAxis reads metricStat.mean vs metricStat.median), so the median series exists and was simply never converted from its own values. Map summaryMedian from summaryMedian, export convertResult for the regression test.
|
@zjncs is attempting to deploy a commit to the codersett's projects Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
convertResultmapsresult.summaryMedianfromresult.summaryMean- a copy-paste of the line above. The blue median dashed line on the Updated Since card renders the mean values, so median and average coincide whenever mean != median, and the median is wrong everywhere they differ.Both sides verified:
ChartDataProviderbuildssummaryMean/summaryMedianfrom distinct API fields (transSummaryToAxisreadsmetricStat.meanvsmetricStat.median), so a genuine median series exists and was simply never converted from its own values.Fix
Map
summaryMedianfromsummaryMedian, and exportconvertResultfor the regression test.Verification
UpdatedSince.test.tsx: givensummaryMean [1,2]/summaryMedian [3,4], the median must convert to[90,120](x30 month-to-day) - RED before (returned[30,60], the converted mean), GREEN after.Risk / conflict disclosure
Open PR #572 touches other hunks of this file (String() casts in the unit const below); this change sits in
convertResultat the top - no overlap, happy to rebase in merge order.