Skip to content

fix: updated-since median reference line plots the mean #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zjncs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: updated-since median reference line plots the mean #609

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions apps/web/src/modules/analyze/DataView/CommunityActivity/UpdatedSince.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
jest.mock('@modules/analyze/components/CardDropDownMenu', () => ({
__esModule: true,
default: () => null,
}));

import { convertResult } from './UpdatedSince';
import { DataContainerResult } from '@modules/analyze/type';

describe('convertResult', () => {
it('converts the median series from its own values, not the mean series', () => {
const result = convertResult({
summaryMean: [1, 2],
summaryMedian: [3, 4],
yResults: [{ name: 'a', data: [1, 2] }],
} as unknown as DataContainerResult);
expect(result.summaryMean).toEqual([30, 60]);
expect(result.summaryMedian).toEqual([90, 120]);
});
});
4 changes: 2 additions & 2 deletions apps/web/src/modules/analyze/DataView/CommunityActivity/UpdatedSince.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@ import { convertMonthsToDays } from '@common/utils/format';
import { DataContainerResult } from '@modules/analyze/type';

// convert months to days.
const convertResult = (result: DataContainerResult) => {
export const convertResult = (result: DataContainerResult) => {
result.summaryMean = result.summaryMean.map((value) =>
convertMonthsToDays(value)
);
result.summaryMedian = result.summaryMean.map((value) =>
result.summaryMedian = result.summaryMedian.map((value) =>
convertMonthsToDays(value)
);
result.yResults = result.yResults.map((item) => {
Expand Down