[zjncs]

Problem

Timer.tsx:15-30 calls setActiveFun() (parent state update) inside a setProgress updater:

setProgress((prevProgress) => {
  if (prevProgress >= 101) {
    setActiveFun();  // ← parent state update inside an updater
    return 0;
  }
  ...
});

Two React-contract violations:

1. State updaters must be pure — React may invoke them twice (StrictMode, interrupted/replayed concurrent renders), double-firing the tab advance. Currently masked by reactStrictMode: false and an idempotent next-name computation; any future non-idempotent change (e.g., advancing an index) double-skips tabs.
2. setActiveFun is a fresh inline closure every parent render and sits in the effect deps, so the interval is torn down/recreated on each parent re-render.

Fix

• Keep the updater pure (advance/wrap only)
• Detect completion in a separate useEffect on progress
• Hold setActiveFun in a ref to stop the interval churn

Verification

Component structure verified: the updater now only computes the next progress value; the advance callback fires from a dedicated effect exactly once per cycle completion.

Risk

None — behavior is identical for the current (StrictMode-off, idempotent) configuration; the fix makes it correct for the general case.

[vercel]

@zjncs is attempting to deploy a commit to the codersett's projects Team on Vercel.

A member of the Team first needs to authorize it.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.