Skip to content

fix: carousel timer no longer calls parent state update inside a setState updater #616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zjncs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: carousel timer no longer calls parent state update inside a setState updater #616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions apps/web/src/modules/academe/CooperationCase/Timer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, { useState, useEffect } from 'react';
import React, { useState, useEffect, useRef } from 'react';
import { Progress } from 'antd';

const Timer = ({
Expand All @@ -12,22 +12,30 @@ const Timer = ({
}) => {
const [progress, setProgress] = useState(0);

// setActiveFun 存 ref：父组件传的 inline 闭包每次渲染都是新引用，
// 放在 effect deps 里导致 interval 频繁重建。
const activeFunRef = useRef(setActiveFun);
activeFunRef.current = setActiveFun;

useEffect(() => {
const interval = setInterval(() => {
!stop &&
setProgress((prevProgress) => {
if (prevProgress >= 101) {
setActiveFun();
return 0;
} else {
return prevProgress + 10 / time;
}
});
setProgress((prevProgress) =>
prevProgress >= 101 ? 0 : prevProgress + 10 / time
);
}, 100);
return () => {
clearInterval(interval);
};
}, [stop, time, setActiveFun]);
}, [stop, time]);

// 到达终点在 effect 中推进（updater 必须是纯函数——React 在 StrictMode
// 与中断渲染下可能重复调用 updater，其中的 setActiveFun 会双触发）。
useEffect(() => {
if (progress >= 101) {
activeFunRef.current();
}
}, [progress]);

return (
<div>
Expand Down