Repository navigation
install: ship the Qt QML headers when OSSIA_QML is on - #964
Merged
Merged
Conversation
js_utilities.hpp, which is installed with the other OSSIA_QT_HEADERS, includes ossia-qt/qml_context.hpp whenever QT_QML_LIB is defined, but OSSIA_QTQML_HEADERS was never installed. Anything compiled against an installed libossia with Qt QML then stops at "'ossia-qt/qml_context.hpp' file not found". score's SDK is one: its add-ons are built with QT_QML_LIB, and any of them that includes score's JS plug-in headers (score-addon-py does) fails to compile. qml_context.hpp in turn includes ossia-qt/score/qml_util.hpp, which was listed with the OSSIA_QML_SCORE headers and so neither compiled into nor installed with a build that has OSSIA_QML on and OSSIA_QML_SCORE off, as score's is. It moves to the OSSIA_QTQML_HEADERS list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sZwhLYYDxKd7Ei5rbEpZJ
jcelerier
temporarily deployed
to
Apple Certificate
October 19, 2026 03:23 — with
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
October 19, 2026 03:23 — with
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
October 19, 2026 03:23 — with
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
October 19, 2026 03:23 — with
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
October 19, 2026 03:23 — with
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
October 19, 2026 03:23 — with
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
October 19, 2026 03:23 — with
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
October 19, 2026 03:23 — with
GitHub Actions
Inactive
jcelerier
temporarily deployed
to
Apple Certificate
October 19, 2026 03:23 — with
GitHub Actions
Inactive
jcelerier
had a problem deploying
to
Apple Certificate
October 19, 2026 03:23 — with
GitHub Actions
Failure
jcelerier
temporarily deployed
to
Apple Certificate
October 19, 2026 03:23 — with
GitHub Actions
Inactive
jcelerier
added a commit
to ossia/score
that referenced
this pull request
Oct 19, 2026
Points to libossia master's install fix (ossia/libossia#964). The SDK installed js_utilities.hpp, which includes ossia-qt/qml_context.hpp under QT_QML_LIB, without installing that header, so an add-on linking score_plugin_js against the SDK failed with "'ossia-qt/qml_context.hpp' file not found" (score-addon-py). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011sZwhLYYDxKd7Ei5rbEpZJ
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
js_utilities.hpp, which is installed with the other OSSIA_QT_HEADERS,
includes ossia-qt/qml_context.hpp whenever QT_QML_LIB is defined, but
OSSIA_QTQML_HEADERS was never installed. Anything compiled against an
installed libossia with Qt QML then stops at "'ossia-qt/qml_context.hpp'
file not found". score's SDK is one: its add-ons are built with
QT_QML_LIB, and any of them that includes score's JS plug-in headers
(score-addon-py does) fails to compile.
qml_context.hpp in turn includes ossia-qt/score/qml_util.hpp, which was
listed with the OSSIA_QML_SCORE headers and so neither compiled into
nor installed with a build that has OSSIA_QML on and OSSIA_QML_SCORE
off, as score's is. It moves to the OSSIA_QTQML_HEADERS list.
Checked by copying the 22 installed headers into a continuous Linux score SDK: score-addon-py, which includes score's
JS/Qml/QmlObjects.hpp, then compiles and links, and every#include <ossia…>in the newly installed headers resolves inside the SDK.🤖 Generated with Claude Code
https://claude.ai/code/session_011sZwhLYYDxKd7Ei5rbEpZJ