Skip to content

AO3-7534 Update text on landing page for media tags - #5946

Open
Mangooomango wants to merge 5 commits into
otwcode:masterfrom
Mangooomango:AO3-7534-Media-Category-tag-pages-edit
Open

AO3-7534 Update text on landing page for media tags#5946
Mangooomango wants to merge 5 commits into
otwcode:masterfrom
Mangooomango:AO3-7534-Media-Category-tag-pages-edit

Conversation

@Mangooomango

Copy link
Copy Markdown

Pull Request Checklist

Issue

https://otwarchive.atlassian.net/browse/AO3-7534

Purpose

What does this PR do?
Instead of always showing "You can use it to filter works and to filter bookmarks" for all Media Category tag pages, it will only show it to then filterable ones. It will show "It's a %{canonical_tag_link}." to no filters.

Testing Instructions

  1. Go to Media Category tags for Theater, Anime, and Manga.
  2. Check that it says "It is a canonical tag." instead of "You can use it to filter works and to filter bookmarks."
  3. Go to canonical tag for different category
  4. Check that it says "You can use it to filter works and to filter bookmarks."
    If you have a Jira account with access, please update or comment on the issue with any new or missing testing instructions instead.

If you have a Jira account with access, please update or comment on the issue
with any new or missing testing instructions instead.

You can remove this section if there are already full testing instructions in the Jira issue.

Credit

Mango (she/her)

If you have a Jira account, please include the same name in the "Full name"
field on your Jira profile, so we can assign you the issues you're working on.

Please note that if you do not fill in this section, we will use your GitHub account name and
they/them pronouns.

Issue
https://otwarchive.atlassian.net/browse/AO3-7534

Purpose
Instead of always showing "You can use it to filter works and to filter bookmarks" for all Media Category tag pages, it will only show it to then filterable ones. It will show "It's a %{canonical_tag_link}." to no filters. 

Testing Instructions
1. Go to Media Category tags for Theater, Anime, and Manga. 
2. Check that it says "It is a canonical tag." instead of "You can use it to filter works and to filter bookmarks."
3. Go to canonical tag for different category 
4. Check that it says "You can use it to filter works and to filter bookmarks."

If you have a Jira account with access, please update or comment on the issue with any new or missing testing instructions instead.

You can remove this section if there are already full testing instructions in the Jira issue.

Credit
Mango (She/her)
Issue
https://otwarchive.atlassian.net/browse/AO3-7534

Purpose
Instead of always showing "You can use it to filter works and to filter bookmarks" for all Media Category tag pages, it will only show it to then filterable ones. It will show "It's a %{canonical_tag_link}." to no filters. 

Testing Instructions
1. Go to Media Category tags for Theater, Anime, and Manga. 
2. Check that it says "It is a canonical tag." instead of "You can use it to filter works and to filter bookmarks."
3. Go to canonical tag for different category 
4. Check that it says "You can use it to filter works and to filter bookmarks."

If you have a Jira account with access, please update or comment on the issue with any new or missing testing instructions instead.

You can remove this section if there are already full testing instructions in the Jira issue.

Credit
Mango (She/her)
@sarken

sarken commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator

Hi, Mango -- welcome back!

It looks like you already have an open pull request for a First Timers Only issue: #5519, which needs action before it can be merged. We ask that each contributor only work on one First Timers Only issue, so we'd appreciate it if you would close one of these two pull requests. Once you've done that, we'll be happy to review the open pull request.

We're also still happy to set you up with Jira permissions as discussed on #5519, so please let us know if that's something you'd be interested in.

Thanks for contributing!

@Mangooomango

Mangooomango commented Jul 27, 2026 via email

Copy link
Copy Markdown
Author

@sarken sarken changed the title Ao3-7534 media category tag pages edit Ao3-7534 Update text on landing page for media tags Jul 28, 2026
@sarken sarken changed the title Ao3-7534 Update text on landing page for media tags AO3-7534 Update text on landing page for media tags Jul 28, 2026
@sarken

sarken commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Thanks for closing the other pull request!

Just to confirm, have you emailed otw-coders@transformativeworks.org with the requested information? We don't appear to have received it, and we can't set up your Jira permissions without your account name and email address.

@Mangooomango

Mangooomango commented Aug 2, 2026 via email

Copy link
Copy Markdown
Author

@sarken sarken left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

Comment thread config/locales/views/en.yml Outdated
Comment on lines +2402 to +2403
canonical_html: It's a %{canonical_tag_link}. You can use it to %{filter_works_link} and to %{filter_bookmarks_link}.
canonical_html_no_filters: It's a %{canonical_tag_link}.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing it this way means needing to translate the same text twice. Sometimes that's unavoidable and even preferable, but in this case, I think it would be better to have

canonical_html: It's a %{canonical_tag_link}.
filterable_html: You can use it to %{filter_works_link} and to %{filter_bookmarks_link}.

That way, we can include canonical_html for all canonical tags and then only include filterable_html when the tag isn't a Media tag, e.g.

# pseudo-code
if canonical
  canonical_html
  if !@tag.is_a?(Media)
    filterable_html
  end
end

@sarken sarken left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be a good idea to add a test to features/tags_and_wrangling/tag_view.feature that shows the text about filtering no longer appears for Media tags but continues to appear for other types. (You don't have to test all the types -- just one would be fine.)

tag_name: Tag name
type: Type
wrangling_status: Wrangling status
show:
canonical_html: It's a %{canonical_tag_link}. You can use it to %{filter_works_link} and to %{filter_bookmarks_link}.
canonical_html: It's a %{canonical_tag_link}.
filterable_html: You can use it to %{filter_works_link} and to %{filter_bookmarks_link}.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to run i18n-tasks to normalize this file and fix this Rspec failure.

filter_bookmarks_link: link_to(t(".filter_bookmarks"), tag_bookmarks_path(@tag))) %>

<% end %>
<% end %>

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably causing some of the test failures. (It might be easier to see why after fixing the indenting.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants