AO3-7534 Update text on landing page for media tags - #5946
Conversation
Issue https://otwarchive.atlassian.net/browse/AO3-7534 Purpose Instead of always showing "You can use it to filter works and to filter bookmarks" for all Media Category tag pages, it will only show it to then filterable ones. It will show "It's a %{canonical_tag_link}." to no filters. Testing Instructions 1. Go to Media Category tags for Theater, Anime, and Manga. 2. Check that it says "It is a canonical tag." instead of "You can use it to filter works and to filter bookmarks." 3. Go to canonical tag for different category 4. Check that it says "You can use it to filter works and to filter bookmarks." If you have a Jira account with access, please update or comment on the issue with any new or missing testing instructions instead. You can remove this section if there are already full testing instructions in the Jira issue. Credit Mango (She/her)
Issue https://otwarchive.atlassian.net/browse/AO3-7534 Purpose Instead of always showing "You can use it to filter works and to filter bookmarks" for all Media Category tag pages, it will only show it to then filterable ones. It will show "It's a %{canonical_tag_link}." to no filters. Testing Instructions 1. Go to Media Category tags for Theater, Anime, and Manga. 2. Check that it says "It is a canonical tag." instead of "You can use it to filter works and to filter bookmarks." 3. Go to canonical tag for different category 4. Check that it says "You can use it to filter works and to filter bookmarks." If you have a Jira account with access, please update or comment on the issue with any new or missing testing instructions instead. You can remove this section if there are already full testing instructions in the Jira issue. Credit Mango (She/her)
|
Hi, Mango -- welcome back! It looks like you already have an open pull request for a First Timers Only issue: #5519, which needs action before it can be merged. We ask that each contributor only work on one First Timers Only issue, so we'd appreciate it if you would close one of these two pull requests. Once you've done that, we'll be happy to review the open pull request. We're also still happy to set you up with Jira permissions as discussed on #5519, so please let us know if that's something you'd be interested in. Thanks for contributing! |
|
Hello!
I have closed the #5519 pull request.
I would also be interested in Jira permissions!
Thank you so much
…On Sun, Jul 26, 2026 at 11:47 PM sarken ***@***.***> wrote:
*sarken* left a comment (otwcode/otwarchive#5946)
<#5946 (comment)>
Hi, Mango -- welcome back!
It looks like you already have an open pull request for a First Timers
Only issue: #5519 <#5519>,
which needs action before it can be merged. We ask that each contributor
only work on one First Timers Only issue, so we'd appreciate it if you
would close one of these two pull requests. Once you've done that, we'll be
happy to review the open pull request.
We're also still happy to set you up with Jira permissions as discussed on
#5519 <#5519>, so please let us
know if that's something you'd be interested in.
Thanks for contributing!
—
Reply to this email directly, view it on GitHub
<#5946?email_source=notifications&email_token=A3QH7TNIJLXH57OU3PKJ3DT5G3GEFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBYG4YDKNJQHE22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5087055095>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3QH7TLNYRKQXKUPW6KUKNL5G3GEFAVCNFSNUABDKJSXA33TNF2G64TZHMYTGMZYGA2DAO2JONZXKZJ3GQ4TOOBRGU3TONRZUF3AE>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/A3QH7TNY75CRF7OKZF4MNNT5G3GEFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBYG4YDKNJQHE22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/A3QH7TPTJEMNZDLCMXTOT635G3GEFA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMBYG4YDKNJQHE22M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Thanks for closing the other pull request! Just to confirm, have you emailed otw-coders@transformativeworks.org with the requested information? We don't appear to have received it, and we can't set up your Jira permissions without your account name and email address. |
|
I have not emailed yet. I will do that now!
Thank you
…On Sat, Aug 1, 2026 at 11:50 PM sarken ***@***.***> wrote:
*sarken* left a comment (otwcode/otwarchive#5946)
<#5946 (comment)>
Thanks for closing the other pull request!
Just to confirm, have you emailed ***@***.*** with
the requested information? We don't appear to have received it, and we
can't set up your Jira permissions without your account name and email
address.
—
Reply to this email directly, view it on GitHub
<#5946?email_source=notifications&email_token=A3QH7TL7QAF5NVKDSQ3UBTD5H23AHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJVGUYDQMRVGU3KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#issuecomment-5155082556>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A3QH7TLCHLR2PRYCSIQ36QL5H23AHAVCNFSNUABDKJSXA33TNF2G64TZHMYTGMZYGA2DAO2JONZXKZJ3GQ4TOOBRGU3TONRZUF3AE>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/A3QH7TJVYDDVOI3QOFFM3VD5H23AHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJVGUYDQMRVGU3KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/A3QH7TLZTKG2LAOKSNZG7I35H23AHA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTKMJVGUYDQMRVGU3KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
sarken
left a comment
There was a problem hiding this comment.
Thanks for working on this!
| canonical_html: It's a %{canonical_tag_link}. You can use it to %{filter_works_link} and to %{filter_bookmarks_link}. | ||
| canonical_html_no_filters: It's a %{canonical_tag_link}. |
There was a problem hiding this comment.
Doing it this way means needing to translate the same text twice. Sometimes that's unavoidable and even preferable, but in this case, I think it would be better to have
canonical_html: It's a %{canonical_tag_link}.
filterable_html: You can use it to %{filter_works_link} and to %{filter_bookmarks_link}.
That way, we can include canonical_html for all canonical tags and then only include filterable_html when the tag isn't a Media tag, e.g.
# pseudo-code
if canonical
canonical_html
if !@tag.is_a?(Media)
filterable_html
end
end
sarken
left a comment
There was a problem hiding this comment.
It would also be a good idea to add a test to features/tags_and_wrangling/tag_view.feature that shows the text about filtering no longer appears for Media tags but continues to appear for other types. (You don't have to test all the types -- just one would be fine.)
| tag_name: Tag name | ||
| type: Type | ||
| wrangling_status: Wrangling status | ||
| show: | ||
| canonical_html: It's a %{canonical_tag_link}. You can use it to %{filter_works_link} and to %{filter_bookmarks_link}. | ||
| canonical_html: It's a %{canonical_tag_link}. | ||
| filterable_html: You can use it to %{filter_works_link} and to %{filter_bookmarks_link}. |
There was a problem hiding this comment.
You'll need to run i18n-tasks to normalize this file and fix this Rspec failure.
| filter_bookmarks_link: link_to(t(".filter_bookmarks"), tag_bookmarks_path(@tag))) %> | ||
|
|
||
| <% end %> | ||
| <% end %> |
There was a problem hiding this comment.
This is probably causing some of the test failures. (It might be easier to see why after fixing the indenting.)
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7534
Purpose
What does this PR do?
Instead of always showing "You can use it to filter works and to filter bookmarks" for all Media Category tag pages, it will only show it to then filterable ones. It will show "It's a %{canonical_tag_link}." to no filters.
Testing Instructions
If you have a Jira account with access, please update or comment on the issue with any new or missing testing instructions instead.
If you have a Jira account with access, please update or comment on the issue
with any new or missing testing instructions instead.
You can remove this section if there are already full testing instructions in the Jira issue.
Credit
Mango (she/her)
If you have a Jira account, please include the same name in the "Full name"
field on your Jira profile, so we can assign you the issues you're working on.
Please note that if you do not fill in this section, we will use your GitHub account name and
they/them pronouns.