Skip to content

AO3-7534 Update text on landing page for media tags #5946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mangooomango wants to merge 5 commits into
base: master
Choose a base branch
from
+12 −4
Open

AO3-7534 Update text on landing page for media tags #5946

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1d06b30
AO3-7534 Update text on Media Category tag pages
Mangooomango Jul 25, 2026
8e474c4
AO3-7534 Update text on Media Category tag pages
Mangooomango Jul 25, 2026
af3ce69
Update en.yml
Mangooomango Aug 6, 2026
22c988e
Update show.html.erb
Mangooomango Aug 6, 2026
9d71b5c
Update show.html.erb
Mangooomango Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions app/views/tags/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,17 @@
<!--main content-->
<p><%= ts("This tag belongs to the %{tag_class} Category.", :tag_class => @tag.class::NAME) %>
<% if @tag.canonical %>
<%= t(".canonical_html",
canonical_tag_link: link_to(t(".canonical_tag"), archive_faq_path("glossary", anchor: "canonicaldef")),
filter_works_link: link_to(t(".filter_works"), tag_works_path(@tag)),
<%= t(".canonical_html",

Check failure on line 27 in app/views/tags/show.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[erb_lint] reported by reviewdog 🐶
Indent with spaces instead of tabs.

Raw Output:
app/views/tags/show.html.erb:27:0: Indent with spaces instead of tabs.
canonical_tag_link: link_to(t(".canonical_tag"), archive_faq_path("glossary", anchor: "canonicaldef"))) %>

Check failure on line 28 in app/views/tags/show.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[erb_lint] reported by reviewdog 🐶
Indent with spaces instead of tabs.

Raw Output:
app/views/tags/show.html.erb:28:0: Indent with spaces instead of tabs.

Check failure on line 28 in app/views/tags/show.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[erb_lint] reported by reviewdog 🐶
Layout/IndentationStyle: Tab detected in indentation.

Raw Output:
app/views/tags/show.html.erb:28:0: Layout/IndentationStyle: Tab detected in indentation.

Check failure on line 28 in app/views/tags/show.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[erb_lint] reported by reviewdog 🐶
Layout/ArgumentAlignment: Use one level of indentation for arguments following the first line of a multi-line method call.

Raw Output:
app/views/tags/show.html.erb:28:4: Layout/ArgumentAlignment: Use one level of indentation for arguments following the first line of a multi-line method call.

Check failure on line 29 in app/views/tags/show.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[erb_lint] reported by reviewdog 🐶
Indent with spaces instead of tabs.

Raw Output:
app/views/tags/show.html.erb:29:0: Indent with spaces instead of tabs.
<% if !@tag.is_a?(Media) %>

Check failure on line 30 in app/views/tags/show.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[erb_lint] reported by reviewdog 🐶
Indent with spaces instead of tabs.

Raw Output:
app/views/tags/show.html.erb:30:0: Indent with spaces instead of tabs.
<%= t(".filterable_html",
filter_works_link: link_to(t(".filter_works"), tag_works_path(@tag)),

Check failure on line 32 in app/views/tags/show.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[erb_lint] reported by reviewdog 🐶
Layout/IndentationStyle: Tab detected in indentation.

Raw Output:
app/views/tags/show.html.erb:32:0: Layout/IndentationStyle: Tab detected in indentation.

Check failure on line 32 in app/views/tags/show.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[erb_lint] reported by reviewdog 🐶
Layout/ArgumentAlignment: Use one level of indentation for arguments following the first line of a multi-line method call.

Raw Output:
app/views/tags/show.html.erb:32:4: Layout/ArgumentAlignment: Use one level of indentation for arguments following the first line of a multi-line method call.
filter_bookmarks_link: link_to(t(".filter_bookmarks"), tag_bookmarks_path(@tag))) %>
<% end %>
<% end %>

@sarken sarken Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably causing some of the test failures. (It might be easier to see why after fixing the indenting.)



Check failure on line 37 in app/views/tags/show.html.erb

View workflow job for this annotation

GitHub Actions / ERB Lint runner 

[erb_lint] reported by reviewdog 🐶
Extra blank line detected.

Raw Output:
app/views/tags/show.html.erb:37:0: Extra blank line detected.
<% if @tag.is_a?(Fandom) %>
<%= t(".list_fandom_tags_html", fandom_relationship_tags_link: link_to(t(".fandom_relationship_tags"), fandom_path(@tag))) %>
<% end %>
Expand Down
3 changes: 2 additions & 1 deletion config/locales/views/en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2399,7 +2399,8 @@ en:
type: Type
wrangling_status: Wrangling status
show:
canonical_html: It's a %{canonical_tag_link}. You can use it to %{filter_works_link} and to %{filter_bookmarks_link}.
canonical_html: It's a %{canonical_tag_link}.
filterable_html: You can use it to %{filter_works_link} and to %{filter_bookmarks_link}.

@sarken sarken Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to run i18n-tasks to normalize this file and fix this Rspec failure.

canonical_tag: canonical tag
fandom_relationship_tags: Relationship tags in this fandom
filter_bookmarks: filter bookmarks
Expand Down
Loading