Validation report - #377
Conversation
Unit Tests Summary 1 files 9 suites 13s ⏱️ Results for commit 8b89f3c. ♻️ This comment has been updated with latest results. |
Code Coverage SummaryDiff against mainResults for commit: 8b89f3c Minimum allowed coverage is ♻️ This comment has been updated with latest results |
findLink() scanned every anchor on the page, so a vignette using the words "validation report" as link text would have been rewritten instead of the navbar item. Scope it to the navbar. closest() and remove() are the only ES6-era APIs in an otherwise strict ES5 file; replace them with equivalents so the target is consistent. pickReport() now takes the maximum eligible report rather than the last match, so REPORTS no longer has to be kept sorted, and the header comment notes that the static fallback in _pkgdown.yml needs updating alongside it.
|
@shajoezhu I pushed 8b89f3c to this branch and filled in the description, since it was empty and the PR also carries the 0.5.13 version sync. Shout if you would rather I had left either alone. Three small things in
Checked the logic with Nice approach, resolving per version is the right call given pkgdown builds a site per tag. One I left alone for you to decide: |
findLink() scanned every anchor on the page, so a vignette using the words "validation report" as link text would have been rewritten instead of the navbar item. Scope it to the navbar. closest() and remove() are the only ES6-era APIs in an otherwise strict ES5 file; replace them with equivalents so the target is consistent. pickReport() now takes the maximum eligible report rather than the last match, so REPORTS no longer has to be kept sorted, and the header comment notes that the static fallback in _pkgdown.yml needs updating alongside it. Mirrors the same fixes on pharmaverse/formatters#377.
findLink() scanned every anchor on the page, so a vignette using the words "validation report" as link text would have been rewritten instead of the navbar item. Scope it to the navbar. closest() and remove() are the only ES6-era APIs in an otherwise strict ES5 file; replace them with equivalents so the target is consistent. pickReport() now takes the maximum eligible report rather than the last match, so REPORTS no longer has to be kept sorted, and the header comment notes that the static fallback in _pkgdown.yml needs updating alongside it. Mirrors the same fixes on pharmaverse/formatters#377 and pharmaverse/rtables#1122.
findLink() scanned every anchor on the page, so a vignette using the words "validation report" as link text would have been rewritten instead of the navbar item. Scope it to the navbar. closest() and remove() are the only ES6-era APIs in an otherwise strict ES5 file; replace them with equivalents so the target is consistent. pickReport() now takes the maximum eligible report rather than the last match, so REPORTS no longer has to be kept sorted, and the header comment notes that the static fallback in _pkgdown.yml needs updating alongside it. Mirrors the same fixes on pharmaverse/formatters#377 and pharmaverse/rtables#1122.
**What changes are proposed in this pull request?** * Adds a "Validation report" entry to the pkgdown navbar, resolved per documentation version. (#1533) pkgdown builds one static site per version, so a hardcoded link would freeze at whichever report was current when it was written. `pkgdown/extra.js` reads the version from the navbar and points the link at the newest report at or below it. Doc versions older than the first report drop the item entirely. `_pkgdown.yml` keeps a static href as the fallback for readers with JavaScript disabled. Only 0.9.11 currently has a report, so 0.9.11 and later resolve to it and earlier doc versions get no navbar item. `DESCRIPTION` also swaps `RoxygenNote: 8.0.0` for `Config/roxygen2/version: 8.1.0`, which is unrelated to the navbar link. Same change as pharmaverse/formatters#377 and pharmaverse/rtables#1122. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Melkiades <11279768+Melkiades@users.noreply.github.com> Co-authored-by: Davide Garolini <davide.garolini@roche.com>
**What changes are proposed in this pull request?** * Adds a "Validation report" entry to the pkgdown navbar, resolved per documentation version. (#1122) pkgdown builds one static site per version, so a hardcoded link would freeze at whichever report was current when it was written. `pkgdown/extra.js` reads the version from the navbar and points the link at the newest report at or below it. Doc versions older than the first report drop the item entirely. `_pkgdown.yml` keeps a static href as the fallback for readers with JavaScript disabled. Only 0.6.16 currently has a report, so 0.6.16 and later resolve to it and earlier doc versions get no navbar item. Same change as pharmaverse/formatters#377. --------- Co-authored-by: Melkiades <11279768+Melkiades@users.noreply.github.com>
What changes are proposed in this pull request?
pkgdown builds one static site per version, so a hardcoded link would freeze at whichever report was current when it was written.
pkgdown/extra.jsreads the version from the navbar and points the link at the newest report at or below it. Versions older than the first report drop the item entirely._pkgdown.ymlkeeps a static href as the fallback for readers with JavaScript disabled.Reports currently exist for 0.5.11 and 0.5.12, so a 0.5.13 site links to the 0.5.12 report.
Also in this PR:
DESCRIPTIONmoves toVersion: 0.5.13/Date: 2026-09-15and theNEWS.mdheading follows.v0.5.13was tagged and released on 2026-09-15 butmainwas left at0.5.12.9003, so this brings the branch back in line with the published release. Flagging it because it is not implied by the PR title.