Skip to content

document and export RefFootnote - #1119

Merged
gmbecker merged 6 commits into
mainfrom
export_reffootnote
Sep 26, 2026
Merged

gmbecker merged 6 commits into
mainfrom
export_reffootnote

Conversation

@gmbecker

Copy link
Copy Markdown
Collaborator

@github-actions

github-actions Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

badge

Code Coverage Summary

Filename                     Stmts    Miss  Cover    Missing
-------------------------  -------  ------  -------  --------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
R/00tabletrees.R               894      68  92.39%   20, 72-76, 138, 141, 472, 563-564, 567, 729, 835, 962-963, 1065, 1068, 1070-1071, 1089-1092, 1112, 1227-1230, 1328-1333, 1496, 1597-1600, 1724-1727, 1764-1767, 1773-1778, 1838, 1845, 1941, 2053, 2120, 2123-2126, 2129-2132, 2162, 2195-2196
R/as_html.R                    172      25  85.47%   5-10, 80, 152-157, 162-167, 182-186, 273
R/colby_constructors.R         626      36  94.25%   81, 134, 197-200, 267-270, 411, 427, 1211-1215, 1217-1221, 1302, 1391, 1552, 1591, 1602, 1610, 1613, 1638, 1659, 1805, 2028-2031
R/compare_rtables.R             83      17  79.52%   93-96, 99-102, 115-118, 137, 156-157, 188, 193
R/custom_split_funs.R          265      40  84.91%   127, 132, 138-143, 156, 173-177, 353-358, 375-380, 456, 502, 518-521, 537, 599, 609-610, 612, 624, 668, 693
R/default_split_funs.R         287      22  92.33%   272, 335-338, 349-350, 352, 354, 551-555, 619-622, 685-688
R/format_rcell.R                17       1  94.12%   47
R/indent.R                      13       2  84.62%   40-41
R/index_footnotes.R             66       0  100.00%
R/make_split_fun.R             166      30  81.93%   22-26, 36-39, 52-55, 58-61, 115, 119, 267, 270-273, 278-281, 366, 375, 377, 379, 430
R/make_subset_expr.R           137      14  89.78%   77-92, 169-177, 213, 302, 306, 315
R/summary.R                    144      38  73.61%   35, 80, 178-220, 269, 315-331, 366, 397
R/tree_accessors.R            1287     143  88.89%   110, 139-140, 264, 284, 310, 333, 363, 381, 400-404, 424, 446-449, 576, 603-604, 890-896, 1043, 1062, 1088, 1140, 1216-1217, 1262, 1297, 1335-1340, 1399, 1473-1477, 1495-1504, 1582, 1730, 1752-1753, 1763, 1814, 1835-1840, 1861-1866, 2002, 2043, 2142, 2249, 2262, 2276, 2292, 2301, 2311-2315, 2365-2370, 2573, 2583-2586, 2596, 2621-2624, 2631, 2633-2636, 2758, 2792-2793, 2850, 3154, 3515, 3631, 3665-3690, 3781-3789, 3950, 4024-4030, 4335, 4459, 4544-4549, 4555, 4579-4584, 4632, 4657-4681, 4710-4716
R/tt_afun_utils.R              419      33  92.12%   60, 182, 189, 198-212, 280, 288-289, 507, 515-518, 600-604, 624, 638-640
R/tt_as_df.R                   400      23  94.25%   101-104, 112, 150, 224-227, 369, 388, 458, 477-480, 489, 599, 605, 637, 655, 707
R/tt_compare_tables.R           72       4  94.44%   51, 174, 249, 253
R/tt_compatibility.R           574      70  87.80%   22, 149-150, 193, 198, 329-330, 334-337, 343, 347, 531, 585-588, 625-627, 665, 698, 718, 738-741, 751-754, 799, 816-820, 826-829, 903, 930-933, 942, 1004, 1012, 1023-1026, 1137, 1144, 1172-1186, 1217-1218
R/tt_dotabulation.R           1266      97  92.34%   60, 255, 260, 262, 311, 336, 340-343, 376-379, 402, 435-438, 466-469, 596-597, 665, 852-856, 906, 910, 938-941, 951, 971-975, 982-985, 1249, 1253, 1284, 1388-1391, 1605-1613, 1877-1886, 1968-1971, 1982, 1987, 1992-1993, 1995, 2006, 2011, 2034, 2120-2139
R/tt_export.R                   13       1  92.31%   45
R/tt_from_df.R                  15       0  100.00%
R/tt_paginate.R                535      40  92.52%   74, 122-131, 242, 341-342, 494, 629-632, 653-657, 802-805, 856-863, 940, 943, 961, 968, 971
R/tt_pos_and_access.R          656      33  94.97%   76, 78-80, 105, 166, 262, 329, 438, 512, 516, 724, 726, 734, 740, 754, 764-767, 990, 1007-1010, 1037, 1096-1097, 1110, 1346-1347, 1373-1376, 1658, 1733
R/tt_showmethods.R             162      21  87.04%   56, 91-113, 223, 249, 258, 263, 266-270, 359-360
R/tt_sort.R                    115       6  94.78%   50, 289-292, 300
R/tt_toString.R                439      24  94.53%   125, 355, 377, 390, 400, 406, 409, 415-425, 518, 619, 826-851
R/utils.R                       34       7  79.41%   56, 169-174
R/validate_table_struct.R       84      10  88.10%   80-84, 93-94, 140, 149-150
R/Viewer.R                      61       9  85.25%   46, 50, 60-64, 84, 118
TOTAL                         9002     814  90.96%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 3e8866b

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions

github-actions Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Unit Tests Summary

    1 files     31 suites   1m 54s ⏱️
  257 tests   257 ✅ 0 💤 0 ❌
1 946 runs  1 946 ✅ 0 💤 0 ❌

Results for commit 3e8866b.

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Sep 11, 2026 •

Copy link
Copy Markdown
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
Pagination 💔 $17.33$ $+1.71$ $0$ $0$ $0$ $0$
Tabulation framework 💔 $24.75$ $+1.76$ $0$ $0$ $0$ $0$

Results for commit 2717669

♻️ This comment has been updated with latest results.

Comment thread R/00tabletrees.R Outdated
Comment thread R/00tabletrees.R

@Melkiades Melkiades left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Missing NEWS though

@wwojciech wwojciech linked an issue Sep 20, 2026 that may be closed by this pull request
@wwojciech

wwojciech commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Hi @gmbecker, @Melkiades - is there anything that’s preventing this PR from being merged?

This is a prerequisite for my {junco} PRs, and it’s becoming quite urgent due to the {junco} code freeze.

Thanks!

gmbecker and others added 5 commits September 24, 2026 13:16
Co-authored-by: Davide Garolini <davide.garolini@roche.com>
Signed-off-by: Gabe Becker <gabembecker@gmail.com>
@gmbecker

Copy link
Copy Markdown
Collaborator Author

news added, ready to merge. @Melkiades

@gmbecker
gmbecker enabled auto-merge (squash) September 24, 2026 22:16
@gmbecker

Copy link
Copy Markdown
Collaborator Author

clean checks ready to merge @Melkiades @shajoezhu

@wwojciech
wwojciech requested a review from Melkiades September 25, 2026 08:47

@shajoezhu shajoezhu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @gmbecker

@gmbecker
gmbecker merged commit b58c34e into main Sep 26, 2026
30 checks passed
@gmbecker
gmbecker deleted the export_reffootnote branch September 26, 2026 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export RefFootnote()

4 participants