Keep rich core Djot on the fast HTML path - #277
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #277 +/- ##
============================================
- Coverage 92.26% 92.18% -0.09%
- Complexity 3896 3955 +59
============================================
Files 111 111
Lines 10923 11052 +129
============================================
+ Hits 10078 10188 +110
- Misses 845 864 +19 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Complete the allocation-light conversion work from #276 for the representative rich core workload, and reduce duplicate document scans on authoritative fallback.
The 49,540-byte
carve-benchDjot document now stays on the borrowed path with byte-identical 98,922-byte HTML. It covers headings and sections, title-shaped definition prose, paragraphs, nested strong syntax, unresolved explicit references, tight lists with continuation-shaped nested markers, block quotes, fenced code, and plain-cell tables.Performance
PHP 8.5.9 NTS, tracing JIT, 20 warmups, fastest of five trials with 50 iterations each:
The facade result is now in the same performance band as carve-php on the publication workload (currently documented at 18.41 MB/s), while emitting almost twice the source size as HTML.
How
Correctness
Validation
After this merges,
carve-benchwill be refreshed against the newdev-mainhead as a separate final step.