Repository navigation
Conversation
Runs on pull requests, the merge queue, and pushes to main. The CI job aggregates every check so branch protection needs only one required status. Also gofmt lib/iputils.go so the format check starts green. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This PR adds automated Go quality and Linux build checks and makes a formatting-only source change. It does not change production behavior or introduce the kinds of customer, access, data, or external-system risks that require human review. You can add or adjust custom eligibility rules. Learn more. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
.github/workflows/ci.yml. It runs onpull_requestand pushes tomain, withcontents: readpermissions and actions pinned by SHA.gofmtgofmt -l .must print nothinggo vetgo vet ./...go test -racego test -race -count=1 ./..., which runs the OIDC allowlist, TLS verification/reload and--server-nameregression testsLinux buildCGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -trimpath .CIif: always()and fails unless every job above succeededBranch protection:
CIis the single required status check onmain. The fork does not use a merge queue; #4 removed themerge_grouptrigger this PR originally added. A failed or cancelled job turnsCIred, so it never leaves a required check stuck pending.This PR also gofmts
lib/iputils.go. That file had a pre-existing formatting violation inherited from upstream, and fixing it lets the new check start green.Publishing and deployment are intentionally out of scope. Murmuration #12025 owns the manual publish workflow (immutable GCS binary plus SHA256, with the digest pinned in Terraform). The CLI flag interface (
--tls-cert,--tls-key,--server-name) is unchanged.Verified locally: gofmt clean,
go vet ./...,go test -race -count=1 ./...and the linux/amd64 build all pass.Created via Murmur
🤖 Generated with Claude Code
Note
Add CI workflow: gofmt, vet, race tests, Linux build
Adds a GitHub Actions pipeline in ci.yml for pull requests, merge-queue checks, and pushes to main. Separate jobs run gofmt validation,
go vet, race-enabled tests, and a Linux amd64 build. An aggregate CI job fails unless all required jobs succeed.Macroscope summarized 359a998.
🐞