Repository navigation
CI: publish commit-tagged releases; drop merge_group [murmur:murmuration/vprox-oidc-claim-allowlists] - #4
Merged
Merged
Conversation
CI runs on pull requests and pushes to main. The aggregate CI check is the required status for main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — The workflow will automatically publish public, downloadable releases for every successful commit to the main branch and grants CI permission to write repository contents. Because those artifacts are an outward action that cannot be fully recalled after consumers obtain them, this change should receive human review. You can add or adjust custom eligibility rules. Learn more. |
After CI passes on a main push, publish the binaries the CI build jobs produced (linux/amd64 and linux/arm64) with SHA256SUMS as a release tagged sha-<commit>. Releases are never marked latest, so consumers pin an exact commit. Main runs get per-commit concurrency groups so no merged commit is skipped. Nothing is deployed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
macroscopeapp-nonprod
Bot
dismissed
their stale review
October 11, 2026 18:04
Dismissing prior approval to re-evaluate c1b117b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3. This PR makes two changes to
.github/workflows/ci.yml: it removes the merge-queue trigger, and it publishes a commit-addressed release for every main commit that passes CI.Triggers
pull_requestand on pushes tomain. The fork does not use a merge queue, somerge_groupis removed.CIis still the single required status check.maincommit runs in its own concurrency group, so a run for a merged commit is never cancelled or skipped before it can publish.One binary build
Linux buildjob is now a matrix overamd64andarm64. Each leg builds withCGO_ENABLED=0 -trimpath, so arm64 breakage fails the PR.go version -mprints the embeddedvcs.revisionfor each binary.Publish (main only)
publishruns only onpushtomainand only after the aggregateCIcheck succeeds. It never runs on PRs.Permissions: it is the only job with
contents: write.What it does:
SHA256SUMS.sha-<full commit SHA>, targeted at that exact commit, with--latest=false. Consumers therefore pin an exact commit rather than following "latest".vprox-linux-amd64vprox-linux-arm64SHA256SUMSsha256sum -cformatNothing is deployed. The gateway and the Modal clients should pin the same
sha-<commit>release. Murmuration #12025 copies that approved asset into GCS and verifies it againstSHA256SUMSinstead of rebuilding. The README's new Releases section documents the download and verification commands. The CLI flags (--tls-cert,--tls-key,--server-name) are unchanged.Notes for repo settings
publishalready fails if the tag exists, but immutable releases also stop anyone with write access from replacing assets after publication.github-actions[bot]needs to be allowed to createsha-*tags.Verification
actionlintreports no errors.CGO_ENABLED=0.sha256sum -c SHA256SUMSpassed.Created via Murmur
🤖 Generated with Claude Code
Note
Add commit-tagged release publishing to CI and drop merge_group trigger
SHA256SUMS, and creates a GitHub release taggedsha-<full commit SHA>with amd64 and arm64 binaries and the checksum file. The release is not marked as latest.cijob is now described as the single required check for main.Macroscope summarized c1b117b.
🐞