Repository navigation
Run unpreconditioned LSMR through mlsmr - #485
Merged
Merged
Conversation
…lsmr lsmr and its Golub-Kahan stream are deleted; within's unpreconditioned path runs mlsmr with the identity metric.
schroedk
force-pushed
the
refactor/one-mlsmr
branch
from
November 1, 2026 14:52
aea8d63 to
1e9ff20
Compare
schroedk
marked this pull request as ready for review
November 1, 2026 14:57
…perator With the plain Golub-Kahan stream gone, the lsmr-vs-mlsmr(identity) cases ran the same path twice. Delete them, replace the IdentityOp fixture with IdentityPrecond, and fix the module doc's dangling lsmr link.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #482.
schwarz_precond::lsmrand its plain Golub-Kahan stream are removed.mlsmrwith the newIdentityPrecond { dim }runs LSMR without a preconditioner, and within's unpreconditioned path (PreconditionerConfig::Off, orAdditivewith no factor pair) now uses it.IdentityPrecondhas the same name and shape as faer's, so #365 can swap in faer's type without touching callers.Breaking:
schwarz_precond::lsmris removed.Tests: all Rust tests pass (502), including doctests; clippy is clean. pytest not run (within-py's API is unchanged).
Benchmark (1M obs, 3 FE, best-of runs against the base, with a same-code control): unpreconditioned 200 iterations 0.825 s vs 0.833–0.846 s on 1 thread, parity on 8 threads; additive, batch and adaptive unchanged.