Rewrite as a native xls reader on libxls_jll, and migrate to test item framework - #28
Merged
Merged
Conversation
Migrate tests and CI to the test item framework, remove PkgButler, bump min Julia to 1.12, and modernize repo infrastructure. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Move the package off 0.x to a proper 1.0 major version, and accept 1.0 versions of Queryverse sibling packages in compat. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
davidanthoff
changed the title
This was referenced Aug 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR finishes LibXLS.jl as a native reader for legacy Excel xls files (Excel 97-2003), and migrates the repository to the test item framework.
Native rewrite
deps/machinery with a dependency on the registeredlibxls_jll(v1.6.2; the Yggdrasil recipe dates back to Add builder for libxls JuliaPackaging/Yggdrasil#251). A bump of the jll to libxls 1.6.3 with upstream security fixes is pending in [libxls] Update to v1.6.3 JuliaPackaging/Yggdrasil#14598 (green; the existinglibxls_jll = "1.6.2"compat already covers it).xls_cellAPI.missing), error cells (newCellErrortype showing#DIV/0!etc.), and formula results (numeric, string, bool, and error results).DateTime/Time, honoring both the 1900 date system (including Excel's phantom 1900-02-29) and the 1904 system.Cell values come back as plain Julia values:
Float64,String,Bool,DateTime,Time,CellErrorormissing— no DataValues dependency, so the package is usable directly from the Tables.jl world. It is the xls counterpart to XLSX.jl, which this package deliberately does not cover.Tests
The old
data/book1.xls/book1_1904.xlssuite is ported (with the previously commented-out date expectations now enabled, and the 1904 file verified to produce the same wall-clock dates), and a new suite runs against ExcelReaders'TestData.xlsfixture, cross-checked against the values the xlrd-based ExcelReaders returned for the same file. 3 test items, 112 assertions, green on Windows and in CI.Test item framework migration
@testitems with a TestItemRunner-basedtest/runtests.jljuliaci.yml), PkgButler workflows removed, dependabot addedRelease notes
Version is 1.0.0-DEV; tag as v1.0.0 and register — this must be registered before the companion ExcelReaders PR (queryverse/ExcelReaders.jl#115) can go green.
🤖 Generated with Claude Code