Skip to content

chore(test): remove assertion-free cases and fold duplicate status checks #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dudetru25 merged 2 commits into from
Sep 25, 2026
Merged

chore(test): remove assertion-free cases and fold duplicate status checks #83

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0a4920
chore(test): remove assertion-free cases and fold duplicate status ch…
dudetru25 Sep 24, 2026
d9ed53a
chore(deps): patch fast-uri, js-yaml, and qs audit advisories
dudetru25 Sep 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 16 additions & 15 deletions unity-cursor-toolkit/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

61 changes: 2 additions & 59 deletions unity-cursor-toolkit/test/run-tests.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ const outDir = path.join(__dirname, '..', 'out');

function testTypes() {
console.log('\n── core/types.ts ──');
const { safeJsonParse, ConnectionState } = require(path.join(outDir, 'core', 'types'));
const { safeJsonParse } = require(path.join(outDir, 'core', 'types'));

test('safeJsonParse: valid object', () => {
assert.deepStrictEqual(safeJsonParse('{"command":"ping"}'), { command: 'ping' });
Expand Down Expand Up @@ -404,12 +404,6 @@ function testTypes() {
assert.throws(() => safeJsonParse('[not,json,]'));
});

test('ConnectionState enum has 4 values', () => {
assert.strictEqual(ConnectionState.Disconnected, 'disconnected');
assert.strictEqual(ConnectionState.Connecting, 'connecting');
assert.strictEqual(ConnectionState.Connected, 'connected');
assert.strictEqual(ConnectionState.Reconnecting, 'reconnecting');
});
}

// ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Expand Down Expand Up @@ -437,19 +431,6 @@ function testConnectionUnit() {
conn.dispose();
});

test('send when disconnected does not throw', () => {
const conn = new ConnectionManager();
conn.send('test', { data: 1 });
conn.dispose();
});

test('pauseHeartbeat / resumeHeartbeat when disconnected does not throw', () => {
const conn = new ConnectionManager();
conn.pauseHeartbeat();
conn.resumeHeartbeat();
conn.dispose();
});

test('dispose sets state to Disconnected', () => {
const conn = new ConnectionManager();
conn.dispose();
Expand Down Expand Up @@ -3316,13 +3297,6 @@ function testDebugAdapter() {
session.dispose();
});

test('messages after dispose are silently ignored', () => {
const session = new UnityDebugSession();
session.dispose();
session.handleMessage({ type: 'request', seq: 99, command: 'threads' });
// No error = pass
});

test('unknown command returns failure response', () => {
const session = new UnityDebugSession();
const messages = [];
Expand Down Expand Up @@ -3552,6 +3526,7 @@ function testStatusBarController() {

assert.ok(connectItem.text.includes('plug') || connectItem.text.includes('Unity Attach'), `Got: ${connectItem.text}`);
assert.strictEqual(connectItem.command, 'unity-cursor-toolkit.startConnection');
assert.strictEqual(connectItem.color, undefined, 'No color when disconnected without project');
ctrl.dispose();
});

Expand Down Expand Up @@ -3620,20 +3595,6 @@ function testStatusBarController() {
ctrl.dispose();
});

test('Connected command is NOT startConnection', () => {
const { ctrl, connectItem } = makeController();
ctrl.update(ConnectionState.Connected, 55500);
assert.notStrictEqual(connectItem.command, 'unity-cursor-toolkit.startConnection');
ctrl.dispose();
});

test('Disconnected color is NOT ThemeColor (no project)', () => {
const { ctrl, connectItem } = makeController();
ctrl.update(ConnectionState.Disconnected, null);
assert.strictEqual(connectItem.color, undefined, 'No color when disconnected without project');
ctrl.dispose();
});

test('state transitions update text between calls', () => {
const { ctrl, connectItem } = makeController();

Expand Down Expand Up @@ -4252,22 +4213,6 @@ async function testConsolePanelLogic() {
bridge.dispose();
}

// ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
// project/folderTemplates.ts (template data validation)
// ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━

function testFolderTemplates() {
console.log('\n── project/folderTemplates.ts ──');

// Can't call pickAndGenerateTemplate (needs quickPick), but can validate
// the module loads and exports correctly
const mod = require(path.join(outDir, 'project', 'folderTemplates'));

test('exports pickAndGenerateTemplate function', () => {
assert.strictEqual(typeof mod.pickAndGenerateTemplate, 'function');
});
}

// ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
// viewport/index.ts (webview source guards)
// ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Expand Down Expand Up @@ -4403,8 +4348,6 @@ async function main() {
await testProjectMcpTools();
await testConsolePanelLogic();
testViewportWebviewSource();
testFolderTemplates();

console.log(`\n${'='.repeat(60)}`);
console.log(` ${passed} passed, ${failed} failed, ${passed + failed} total`);

Expand Down
Loading